Bug 1344889 - Add necessary dependendencies for generated libvpx assembly. r=mshal, a=gchang
authorMike Hommey <mh+mozilla@glandium.org>
Thu, 09 Mar 2017 10:54:48 +0900
changeset 395935 927de4d781051ba357e1aebf38babe38129296cb
parent 395934 c790dc13185f059f2d98f3e3ecbf41231b883d58
child 395936 4f854079321183d52b05b04cac4ceb84c067ed83
push id1468
push userasasaki@mozilla.com
push dateMon, 05 Jun 2017 19:31:07 +0000
treeherdermozilla-release@0641fc6ee9d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmshal, gchang
bugs1344889
milestone54.0
Bug 1344889 - Add necessary dependendencies for generated libvpx assembly. r=mshal, a=gchang
media/libvpx/Makefile.in
--- a/media/libvpx/Makefile.in
+++ b/media/libvpx/Makefile.in
@@ -1,22 +1,25 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 # Set up the libvpx assembler config.
 
+include $(topsrcdir)/config/rules.mk
+
 ifdef VPX_ARM_ASM
 
 ifdef VPX_AS_CONVERSION
 # The ARM asm is written in ARM RVCT syntax, but we actually build it with
 # gas using GNU syntax. Add some rules to perform the conversion.
 
 # Previously used $(dir $(ASFILES)) to figure out which directories to generate.
 # However, .S (as opposed to .s) files are not added to ASFILES. There is only
 # one directory with arm assembly currently so enumerate it manually.
 GENERATED_DIRS += libvpx/vpx_dsp/arm
 
-%.asm.S: %.asm $(ASM_OFFSETS)
+%.asm.S: %.asm $(ASM_OFFSETS) $(call mkdir_deps,libvpx/vpx_dsp/arm)
 	$(VPX_AS_CONVERSION) < $< > $@
 
+$(addsuffix .$(OBJ_SUFFIX), idct4x4_add_neon.asm idct8x8_add_neon.asm idct16x16_add_neon.asm): libvpx/vpx_dsp/arm/idct_neon.asm.S
 endif
 endif