Bug 948233 - Fix an OOM issue in DoCompareFallback. r=jandem, a=lsblakk
authorChristian Holler <choller@mozilla.com>
Tue, 10 Dec 2013 12:24:06 +0100
changeset 175276 8f29c6506b23f71107507619038ad9dd39a17662
parent 175275 75a2bbd8c4b64fa27abc5f982fb5e822015b3c4c
child 175277 c6eb37cebcd9e985507cda1ef33eefab1156fa61
push id445
push userffxbld
push dateMon, 10 Mar 2014 22:05:19 +0000
treeherdermozilla-release@dc38b741b04e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem, lsblakk
bugs948233
milestone28.0a2
Bug 948233 - Fix an OOM issue in DoCompareFallback. r=jandem, a=lsblakk
js/src/jit/BaselineIC.cpp
--- a/js/src/jit/BaselineIC.cpp
+++ b/js/src/jit/BaselineIC.cpp
@@ -1810,17 +1810,17 @@ DoCompareFallback(JSContext *cx, Baselin
     if ((lhs.isNumber() && rhs.isUndefined()) ||
         (lhs.isUndefined() && rhs.isNumber()))
     {
         IonSpew(IonSpew_BaselineIC, "  Generating %s(%s, %s) stub", js_CodeName[op],
                     rhs.isUndefined() ? "Number" : "Undefined",
                     rhs.isUndefined() ? "Undefined" : "Number");
         ICCompare_NumberWithUndefined::Compiler compiler(cx, op, lhs.isUndefined());
         ICStub *doubleStub = compiler.getStub(compiler.getStubSpace(script));
-        if (!stub)
+        if (!doubleStub)
             return false;
 
         stub->addNewStub(doubleStub);
         return true;
     }
 
     if (lhs.isBoolean() && rhs.isBoolean()) {
         IonSpew(IonSpew_BaselineIC, "  Generating %s(Boolean, Boolean) stub", js_CodeName[op]);