Bug 960931: Remove unused variables from tests r=ato
authorDavid Burns <dburns@mozilla.com>
Wed, 25 May 2016 15:31:51 +0100
changeset 340196 8e7bb0f5c506a5fadb406f9a598bfe2231298490
parent 340195 050485808a590c3db6c2bf001a1c18897d26db04
child 340197 8585521af418b7ad5b65e908692b9951d59375b2
push id1183
push userraliiev@mozilla.com
push dateMon, 05 Sep 2016 20:01:49 +0000
treeherdermozilla-release@3148731bed45 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersato
bugs960931
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 960931: Remove unused variables from tests r=ato We create the variables with what is returned from the session creation but never do anything with them. MozReview-Commit-ID: LDZQrtqdniB
testing/marionette/harness/marionette/tests/unit/test_session.py
--- a/testing/marionette/harness/marionette/tests/unit/test_session.py
+++ b/testing/marionette/harness/marionette/tests/unit/test_session.py
@@ -26,24 +26,24 @@ class TestSession(MarionetteTestCase):
         # Optional capabilities we want Marionette to support
         self.assertIn("device", caps)
         self.assertIn("rotatable", caps)
         self.assertIn("takesScreenshot", caps)
         self.assertIn("version", caps)
 
     def test_we_can_get_the_session_id(self):
         # Sends newSession
-        caps = self.marionette.start_session()
+        self.marionette.start_session()
 
         self.assertTrue(self.marionette.session_id is not None)
         self.assertTrue(isinstance(self.marionette.session_id, unicode))
 
     def test_we_can_set_the_session_id(self):
         # Sends newSession
-        caps = self.marionette.start_session(session_id="ILoveCheese")
+        self.marionette.start_session(session_id="ILoveCheese")
 
         self.assertEqual(self.marionette.session_id, "ILoveCheese")
         self.assertTrue(isinstance(self.marionette.session_id, unicode))
 
     def test_we_only_support_one_active_session_at_a_time(self):
         self.marionette.start_session()
         self.assertTrue(isinstance(self.marionette.session_id, unicode))
         self.assertRaises(SessionNotCreatedException, self.marionette._send_message, "newSession", {})