Bug 1485289 - Use BeginWriting() instead of GetMutableData() in LateWriteChecks. r=froydnj
authorHenri Sivonen <hsivonen@hsivonen.fi>
Tue, 28 Aug 2018 14:50:11 +0000
changeset 491326 8e03f957959dad0e0da538d975b60cf650237c3e
parent 491325 6d95f23e7ea20ff6b2a5dbd0af8627c60d3b1d1c
child 491327 9494c03553b9b968194c78602fb75273d39d9ede
push id1815
push userffxbld-merge
push dateMon, 15 Oct 2018 10:40:45 +0000
treeherdermozilla-release@18d4c09e9378 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1485289
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1485289 - Use BeginWriting() instead of GetMutableData() in LateWriteChecks. r=froydnj MozReview-Commit-ID: G64L8b6wnO0 Differential Revision: https://phabricator.services.mozilla.com/D3963
xpcom/build/LateWriteChecks.cpp
--- a/xpcom/build/LateWriteChecks.cpp
+++ b/xpcom/build/LateWriteChecks.cpp
@@ -128,18 +128,17 @@ LateWriteObserver::Observe(IOInterposeOb
   std::vector<uintptr_t> rawStack;
 
   MozStackWalk(RecordStackWalker, /* skipFrames */ 0, /* maxFrames */ 0,
                &rawStack);
   Telemetry::ProcessedStack stack = Telemetry::GetStackAndModules(rawStack);
 
   nsTAutoString<char_type> nameAux(mProfileDirectory);
   nameAux.AppendLiteral(NS_SLASH "Telemetry.LateWriteTmpXXXXXX");
-  char_type* name;
-  nameAux.GetMutableData(&name);
+  char_type* name = nameAux.BeginWriting();
 
   // We want the sha1 of the entire file, so please don't write to fd
   // directly; use sha1Stream.
   FILE* stream;
 #ifdef XP_WIN
   HANDLE hFile;
   do {
     // mkstemp isn't supported so keep trying until we get a file