Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester a=test-only
authorAndreas Tolfsen <ato@mozilla.com>
Thu, 17 Mar 2016 14:57:46 +0000
changeset 325988 89dadb7edac9c770edd67db7d7e0a6f8871897ff
parent 325987 c6a28b230c749d4313e5ba8dc456f35a930f95ca
child 325989 53cc812c5ef7964f31767bc2e2e5007ec23a64da
push id1128
push userjlund@mozilla.com
push dateWed, 01 Jun 2016 01:31:59 +0000
treeherdermozilla-release@fe0d30de989d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersautomatedtester, test-only
bugs1257526
milestone47.0a2
Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester a=test-only Throw unsupported operation errors the same way throughout Marionette. MozReview-Commit-ID: D63gVIeX2qK
testing/marionette/driver.js
--- a/testing/marionette/driver.js
+++ b/testing/marionette/driver.js
@@ -2642,18 +2642,18 @@ GeckoDriver.prototype.getWindowSize = fu
  * Not supported on B2G. The supplied width and height values refer to
  * the window outerWidth and outerHeight values, which include scroll
  * bars, title bars, etc.
  *
  * An error will be returned if the requested window size would result
  * in the window being in the maximized state.
  */
 GeckoDriver.prototype.setWindowSize = function(cmd, resp) {
-  if (this.appName !== "Firefox") {
-    throw new UnsupportedOperationError("Not supported on mobile");
+  if (this.appName != "Firefox") {
+    throw new UnsupportedOperationError();
   }
 
   let width = parseInt(cmd.parameters.width);
   let height = parseInt(cmd.parameters.height);
 
   let win = this.getCurrentWindow();
   if (width >= win.screen.availWidth && height >= win.screen.availHeight) {
     throw new UnsupportedOperationError("Invalid requested size, cannot maximize");
@@ -2665,17 +2665,17 @@ GeckoDriver.prototype.setWindowSize = fu
 /**
  * Maximizes the user agent window as if the user pressed the maximise
  * button.
  *
  * Not Supported on B2G or Fennec.
  */
 GeckoDriver.prototype.maximizeWindow = function(cmd, resp) {
   if (this.appName != "Firefox") {
-    throw new UnsupportedOperationError("Not supported for mobile");
+    throw new UnsupportedOperationError();
   }
 
   let win = this.getCurrentWindow();
   win.moveTo(0,0);
   win.resizeTo(win.screen.availWidth, win.screen.availHeight);
 };
 
 /**