Bug 1524208: Compare result of BaseInputPin::Receive to S_OK. r=pehrsons, a=abillings
authorDan Minor <dminor@mozilla.com>
Wed, 13 Feb 2019 06:33:27 -0800
changeset 516065 89ac71e3fa34388c0698a5af2e831a336a858052
parent 516064 820b728e1ebe6dd1b211c9a8feb677104719b5ab
child 516066 f0f6ce3aa0f68e4e268dff78da5c9773437f6670
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspehrsons, abillings
bugs1524208
milestone66.0
Bug 1524208: Compare result of BaseInputPin::Receive to S_OK. r=pehrsons, a=abillings Differential Revision: https://phabricator.services.mozilla.com/D19675
media/webrtc/trunk/webrtc/modules/video_capture/windows/sink_filter_ds.cc
--- a/media/webrtc/trunk/webrtc/modules/video_capture/windows/sink_filter_ds.cc
+++ b/media/webrtc/trunk/webrtc/modules/video_capture/windows/sink_filter_ds.cc
@@ -314,17 +314,17 @@ CaptureInputPin::Receive(IN IMediaSample
     __except (EXCEPTION_CONTINUE_EXECUTION)
     {
     }
   }
 
   reinterpret_cast<CaptureSinkFilter*>(mFilter)->LockReceive();
   hr = BaseInputPin::Receive(pIMediaSample);
 
-  if (SUCCEEDED(hr)) {
+  if (hr == S_OK) {
     const int32_t length = pIMediaSample->GetActualDataLength();
 
     unsigned char* pBuffer = NULL;
     if (S_OK != pIMediaSample->GetPointer(&pBuffer)) {
       reinterpret_cast <CaptureSinkFilter *>(mFilter)->UnlockReceive();
       return S_FALSE;
     }