Bug 1294355 - Pass correct arguments to openLocationInDebugger in console stack trace. r=bgrins, a=ritu
authorJarda Snajdr <jsnajdr@gmail.com>
Thu, 18 Aug 2016 09:36:45 +0200
changeset 349905 86ea9bc05db39457487dc04a0e03805845f210ee
parent 349904 35a1c9a9d263fd9343834162a4bb4e4435ac03ac
child 349906 b41ad28f49b25f11c30b917dbeacfe8afae0b7a4
push id1230
push userjlund@mozilla.com
push dateMon, 31 Oct 2016 18:13:35 +0000
treeherdermozilla-release@5e06e3766db2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbgrins, ritu
bugs1294355
milestone50.0a2
Bug 1294355 - Pass correct arguments to openLocationInDebugger in console stack trace. r=bgrins, a=ritu MozReview-Commit-ID: KvSZ3fi5Kne
devtools/client/webconsole/console-output.js
--- a/devtools/client/webconsole/console-output.js
+++ b/devtools/client/webconsole/console-output.js
@@ -3546,35 +3546,28 @@ Widgets.Stacktrace = function (message, 
 
 Widgets.Stacktrace.prototype = extend(Widgets.BaseWidget.prototype, {
   /**
    * The stackframes received from the server.
    * @type array
    */
   stacktrace: null,
 
-  onViewSourceInDebugger(frame) {
-    this.output.openLocationInDebugger({
-      url: frame.source,
-      line: frame.line
-    });
-  },
-
   render() {
     if (this.element) {
       return this;
     }
 
     let result = this.element = this.document.createElementNS(XHTML_NS, "div");
     result.className = "stacktrace devtools-monospace";
 
     if (this.stacktrace) {
       this.output.owner.ReactDOM.render(this.output.owner.StackTraceView({
         stacktrace: this.stacktrace,
-        onViewSourceInDebugger: frame => this.onViewSourceInDebugger(frame)
+        onViewSourceInDebugger: frame => this.output.openLocationInDebugger(frame)
       }), result);
     }
 
     return this;
   }
 });
 
 /**