Bug 1471062 - Make heap-analysis/byteSize-of-scripts jit-test more complex r=jandem,arai
authorTed Campbell <tcampbell@mozilla.com>
Wed, 26 Jun 2019 15:36:43 +0000
changeset 543069 83a5257788cbc7038e23b1688b2b6d20c59504bc
parent 543068 699e6677280fceb1e755a03933629ac01104d407
child 543070 0964e2a0ed2905151cef7aab24722ae133085715
push id2131
push userffxbld-merge
push dateMon, 26 Aug 2019 18:30:20 +0000
treeherdermozilla-release@b19ffb3ca153 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem, arai
bugs1471062
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1471062 - Make heap-analysis/byteSize-of-scripts jit-test more complex r=jandem,arai As PrivateScriptData contains less data, we need to make this test have more complicated functions so that the test is not sensistive to allocator rounding. This also removes the binjs variant of test until they next time they are regenerated. Differential Revision: https://phabricator.services.mozilla.com/D35840
js/src/jit-test/tests/binast/lazy/heap-analysis/byteSize-of-scripts.binjs
js/src/jit-test/tests/binast/nonlazy/heap-analysis/byteSize-of-scripts.binjs
js/src/jit-test/tests/heap-analysis/byteSize-of-scripts.js
deleted file mode 100644
index 65f60f8904fd21d8a14869718c1527edb51a7b61..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100644
index 07ad590709afc7b8f4a2433d7b98877bcbeae1cc..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
--- a/js/src/jit-test/tests/heap-analysis/byteSize-of-scripts.js
+++ b/js/src/jit-test/tests/heap-analysis/byteSize-of-scripts.js
@@ -13,33 +13,37 @@ function f2(n) {
   var obj = {
     x: 1,
     y: 2,
     z: 3,
   };
 
   if (i % 2 == 0) {
     for (var i = 0; i < n; i++) {
-      this.x += i;
-      print(uneval(i));
-      obj[i] = i * i;
-      if (i > 10) {
-        f2(i / f1());
-      }
+      (function() {
+        this.x += i;
+        print(uneval(i));
+        obj[i] = i * i;
+        if (i > 10) {
+          f2(i / f1());
+        }
+      })();
     }
   }
 
   if (i % 3 == 0) {
     for (var i = 0; i < n; i++) {
-      this.x *= i;
-      print(uneval(i));
-      obj[i] = i * i;
-      if (i > 10) {
-        f2(i / f1());
-      }
+      (function() {
+        this.x *= i;
+        print(uneval(i));
+        obj[i] = i * i;
+        if (i > 10) {
+          f2(i / f1());
+        }
+      })();
     }
   }
 
   return this.x;
 }
 
 print("byteSizeOfScript(f2) = " + byteSizeOfScript(f2));
 assertEq(byteSizeOfScript(f2) > 1, true);