Bug 1522964 - Re-enable scroll anchoring on Fennec with gofaster intervention. r=dholbert a=lizzard
authorRyan Hunt <rhunt@eqrion.net>
Fri, 25 Jan 2019 21:08:44 +0000
changeset 515785 820fe56860e101a06a9dc6981576f7eb281b1722
parent 515784 6f1e1adbccb026ce89384465c7a425916d159a22
child 515786 7d9ca706a2a3c97121801502c8e600db35e6ac2d
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert, lizzard
bugs1522964
milestone66.0
Bug 1522964 - Re-enable scroll anchoring on Fennec with gofaster intervention. r=dholbert a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D17677
mobile/android/app/geckoview-prefs.js
modules/libpref/init/StaticPrefList.h
--- a/mobile/android/app/geckoview-prefs.js
+++ b/mobile/android/app/geckoview-prefs.js
@@ -30,14 +30,10 @@ pref("geckoview.logging", "Debug");
 pref("dom.push.enabled", false);
 
 // Unlike Fennec, GeckoView may have WebRender enabled, and with WebRender we're
 // going with containerless scrolling (because there are no layers at all with
 // WR, so why not go containerless). So we set this pref to pick up the value
 // in gfxPrefs.h from whether or not WR is enabled.
 pref("layout.scroll.root-frame-containers", 2);
 
-// Scroll anchoring is disabled in Fennec but not GeckoView because of
-// regressions involving the dynamic toolbar. See bug 1520666 for more details.
-pref("layout.css.scroll-anchoring.enabled", true);
-
 // Inherit locale from the OS, used for multi-locale builds
 pref("intl.locale.requested", "");
--- a/modules/libpref/init/StaticPrefList.h
+++ b/modules/libpref/init/StaticPrefList.h
@@ -914,27 +914,21 @@ VARCACHE_PREF(
 // Are dynamic reflow roots enabled?
 VARCACHE_PREF(
    "layout.dynamic-reflow-roots.enabled",
    layout_dynamic_reflow_roots_enabled,
   bool, true
 )
 
 // Pref to control enabling scroll anchoring.
-#ifndef ANDROID
-#define PREF_VALUE true
-#else
-#define PREF_VALUE false
-#endif
 VARCACHE_PREF(
   "layout.css.scroll-anchoring.enabled",
    layout_css_scroll_anchoring_enabled,
-  bool, PREF_VALUE
+  bool, true
 )
-#undef PREF_VALUE
 
 VARCACHE_PREF(
   "layout.css.scroll-anchoring.highlight",
    layout_css_scroll_anchoring_highlight,
   bool, false
 )
 
 //---------------------------------------------------------------------------