Bug 1547937 - Fix old about:debugging backgrounds and colors for dark mode. r=dao
authorKestrel <ke5trel@protonmail.com>
Thu, 09 May 2019 18:27:47 +0000
changeset 535169 81a322420af9c208dd466ad17e4c1a55e17fa042
parent 535168 f7f94d7b7d82c247c9c9b9a34d2f0045a07e85dd
child 535170 749343db5bbd4d56eab91abf0a475e0d9970eff4
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1547937
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1547937 - Fix old about:debugging backgrounds and colors for dark mode. r=dao Differential Revision: https://phabricator.services.mozilla.com/D29335
devtools/client/aboutdebugging/aboutdebugging.css
--- a/devtools/client/aboutdebugging/aboutdebugging.css
+++ b/devtools/client/aboutdebugging/aboutdebugging.css
@@ -55,16 +55,23 @@ button {
 
 .panel {
   max-width: 800px;
   margin-bottom: 35px;
 }
 
 /* Targets */
 
+.target-icon,
+.addons-tip-icon,
+.warning {
+  -moz-context-properties: fill;
+  fill: currentColor;
+}
+
 .target-list {
   margin: 0;
   padding: 0;
 }
 
 .target-container {
   margin-top: 5px;
   min-height: 34px;
@@ -139,21 +146,23 @@ button {
   border-width: 1px;
   border-style: solid;
 
   font-size: 0.6em;
   text-align: center;
 }
 
 .target-status-stopped {
+  color: var(--grey-90);
   border-color: grey;
   background-color: lightgrey;
 }
 
 .target-status-running {
+  color: var(--grey-90);
   border-color: limegreen;
   background-color: palegreen;
 }
 
 .target-name {
   white-space: nowrap;
   overflow: hidden;
   text-overflow: ellipsis;
@@ -168,48 +177,39 @@ button {
 .service-worker-multi-process {
   padding: 5px 10px;
   margin-top: 5px;
   margin-inline-end: 4px;
 }
 
 .addons-install-error {
   align-items: center;
-  background-color: #f3b0b0;
+  background-color: rgb(222, 33, 33, 0.3);
   display: flex;
   justify-content: space-between;
 }
 
 .service-worker-multi-process {
-  background-color: #ffeebb;
+  background-color: rgb(255, 191, 0, 0.3);
   line-height: 1.5em;
 }
 
 .service-worker-multi-process .update-button {
   margin: 5px 0;
 }
 
 .warning {
   display: inline-block;
   width: 12px;
   height: 12px;
   vertical-align: 0;
   margin-inline-end: 8px;
   background-image: url(chrome://devtools/skin/images/alert.svg);
   background-repeat: no-repeat;
   background-size: contain;
-  -moz-context-properties: fill;
-  fill: #d7b600;
-}
-
-.addons-install-error .warning,
-.service-worker-multi-process .warning {
-  /* The warning icon can be hard to see on red / yellow backgrounds, this turns the icon
-  to a black icon. */
-  fill: #0c0c0d;
 }
 
 .addons-install-error__additional-errors {
   font-family: monospace;
   font-size: 13px;
   margin-block: 8px;
 }
 
@@ -280,17 +280,17 @@ button {
 
 .target-card-heading-icon {
   height: 24px;
   width: 24px;
   margin-inline-end: 16px;
 }
 
 .target-card-actions {
-  border-top: 1px solid rgba(0, 0, 0, 0.2);
+  border-top: 1px solid var(--in-content-border-color);
   padding-top: 16px;
 }
 
 .target-card-action-link {
   background: none;
   border: none;
   /* !important overrides the common.css button color */
   color: var(--in-content-link-color) !important;