Bug 1254395 - push to cdn for non release promotion case doesn't use credentials, DONTBUILD a=testing r=nthomas
authorJordan Lund <jlund@mozilla.com>
Mon, 07 Mar 2016 18:52:51 -0800
changeset 325255 81073d864073e7c8c371836ae0b060366f9b6f62
parent 325254 9a446438d3a4e9279b776d3e296e7a7209acab77
child 325256 ce9a5e723e4b21ce0dac5ede64e156023bb70534
push id1128
push userjlund@mozilla.com
push dateWed, 01 Jun 2016 01:31:59 +0000
treeherdermozilla-release@fe0d30de989d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstesting, nthomas
bugs1254395
milestone47.0a2
Bug 1254395 - push to cdn for non release promotion case doesn't use credentials, DONTBUILD a=testing r=nthomas MozReview-Commit-ID: AYbMZVNxwo
testing/mozharness/scripts/release/push-candidate-to-releases.py
--- a/testing/mozharness/scripts/release/push-candidate-to-releases.py
+++ b/testing/mozharness/scripts/release/push-candidate-to-releases.py
@@ -72,17 +72,17 @@ class ReleasePusher(BaseScript, Virtuale
 
         # validate aws credentials
         if not (all(aws_creds) or self.config.get('credentials')):
             self.fatal("aws creds not defined. please add them to your config or env.")
         if any(aws_creds) and self.config.get('credentials'):
             self.fatal("aws creds found in env and self.config. please declare in one place only.")
 
         # set aws credentials
-        if aws_creds:
+        if all(aws_creds):
             self.aws_key_id, self.aws_secret_key = aws_creds
         else:  # use
             self.aws_key_id, self.aws_secret_key = None, None
             # set the env var for boto to read our special config file
             # rather than anything else we have at ~/.boto
             os.environ["BOTO_CONFIG"] = os.path.abspath(self.config["credentials"])
 
     def _pre_config_lock(self, rw_config):