Bug 1431028 - Move the gfx warning to the correct position. r=mattwoodrow
authorJerryShih <hshih@mozilla.com>
Wed, 17 Jan 2018 02:19:00 -0500
changeset 454227 80b5219aedd81f12b2e234178a3ca1159fe49feb
parent 454226 8a880591214558414d6a1c6a87280d65feb9dabf
child 454279 b572d99d0febdf94f140838c7c29867b873aa9e1
push id1648
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 12:45:47 +0000
treeherdermozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow
bugs1431028
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1431028 - Move the gfx warning to the correct position. r=mattwoodrow We should only show the warning message when we have the on-white buffer. MozReview-Commit-ID: 4gzo0reYIVL
gfx/layers/client/SingleTiledContentClient.cpp
--- a/gfx/layers/client/SingleTiledContentClient.cpp
+++ b/gfx/layers/client/SingleTiledContentClient.cpp
@@ -237,19 +237,19 @@ ClientSingleTiledLayerBuffer::PaintThebe
                   frontBufferOnWhite, dtOnWhite, rect, dest
                 };
                 if (asyncPaint) {
                   paintCopies.push_back(copy);
                 } else {
                   copy.CopyBuffer();
                 }
               }
+            } else {
+              gfxWarning() << "[Tiling:Client] Failed to aquire the discarded front buffer's draw target";
             }
-          } else {
-            gfxWarning() << "[Tiling:Client] Failed to aquire the discarded front buffer's draw target";
           }
         } else {
           gfxWarning() << "[Tiling:Client] Failed to aquire the discarded front buffer's draw target";
         }
 
         TILING_LOG("TILING %p: Region copied from discarded frontbuffer %s\n", &mPaintedLayer, Stringify(copyableRegion).c_str());
 
         // We don't need to repaint valid content that was just copied.