Bug 1520456 - test_CF_HTML_clipboard.html should skip non-mac platform instead of detecting platform in html file. r=masayuki a=test-only DEVEDITION_68_0b5_BUILD1 DEVEDITION_68_0b5_RELEASE FENNEC_68_0b5_BUILD1 FENNEC_68_0b5_RELEASE FIREFOX_68_0b5_BUILD1 FIREFOX_68_0b5_RELEASE
authorMakoto Kato <m_kato@ga2.so-net.ne.jp>
Fri, 24 May 2019 06:28:02 +0000
changeset 536490 7f83ca2147b8a9f3b7e5e6c6c5daae76be1c82a8
parent 536489 8a9ead04803465749d2cb41a9ca00cc72a050815
child 536491 ad152a2a5739fa05cc834d41236a6efb5ef8f187
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmasayuki, test-only
bugs1520456
milestone68.0
Bug 1520456 - test_CF_HTML_clipboard.html should skip non-mac platform instead of detecting platform in html file. r=masayuki a=test-only test_CF_HTML_clipboard.html does nothing if platform isn't mac. But according to intermittent failure log, this is often failure on Android. I guess that this is infra issue, but we should use skip-if to avoid this failure instead. Differential Revision: https://phabricator.services.mozilla.com/D32413
editor/libeditor/tests/mochitest.ini
editor/libeditor/tests/test_CF_HTML_clipboard.html
--- a/editor/libeditor/tests/mochitest.ini
+++ b/editor/libeditor/tests/mochitest.ini
@@ -263,16 +263,17 @@ skip-if = toolkit == 'android' # bug 131
 [test_bug1497480.html]
 skip-if = toolkit == 'android'
 
 [test_abs_positioner_appearance.html]
 [test_abs_positioner_positioning_elements.html]
 skip-if = os == 'android' # Bug 1525959
 [test_CF_HTML_clipboard.html]
 tags = clipboard
+skip-if = os != 'mac' # bug 574005
 [test_composition_event_created_in_chrome.html]
 [test_contenteditable_focus.html]
 [test_documentCharacterSet.html]
 [test_dom_input_event_on_htmleditor.html]
 [test_dom_input_event_on_texteditor.html]
 [test_dragdrop.html]
 skip-if = os == 'android'
 [test_handle_new_lines.html]
--- a/editor/libeditor/tests/test_CF_HTML_clipboard.html
+++ b/editor/libeditor/tests/test_CF_HTML_clipboard.html
@@ -136,21 +136,13 @@ function runTest() {
         }, {once: true});
         win.focus();
       }, 0);
     }, {once: true});
     iframe.srcdoc = "foo";
   }, SimpleTest.finish);
 }
 
-var isMac = ("nsILocalFileMac" in SpecialPowers.Ci);
-if (isMac) {
-  SimpleTest.waitForFocus(runTest);
-} else {
-  // This test is not yet supported on non-Mac platforms, see bug 574005.
-  todo(false, "Test not supported on this platform");
-  SimpleTest.finish();
-}
-
+SimpleTest.waitForFocus(runTest);
 </script>
 </pre>
 </body>
 </html>