Bug 1569672 - Collect use counter denominators in release. r=janerik a=jcristau FIREFOX_68_0_2_BUILD1 FIREFOX_68_0_2_RELEASE
authorTim D. Smith <tdsmith@mozilla.com>
Tue, 30 Jul 2019 08:07:08 +0000
changeset 537286 7ece03f6971968eede29275477502309bbe399da
parent 537285 faec47a63ba1eaa2b10f03200b9c28785172b2e6
child 537287 7a1e69006831e3708f54e7c9b6f96a02a07e85f7
push id2126
push userjcristau@mozilla.com
push dateTue, 13 Aug 2019 15:04:48 +0000
treeherdermozilla-release@7ece03f69719 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjanerik, jcristau
bugs1569672, 1477433, 1204994
milestone68.0.2
Bug 1569672 - Collect use counter denominators in release. r=janerik a=jcristau Use counters are collected in release as of bug 1477433. Per bug 1204994, use counters need to be interpreted relative to CONTENT_DOCUMENTS_DESTROYED and TOP_LEVEL_CONTENT_DOCUMENTS_DESTROYED, so these need to be collected in release, as well. Also cleans up probe definitions and removes from whitelists. Differential Revision: https://phabricator.services.mozilla.com/D39726
toolkit/components/telemetry/Histograms.json
toolkit/components/telemetry/histogram-whitelists.json
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -12704,22 +12704,28 @@
     "n_values": 10,
     "releaseChannelCollection": "opt-out",
     "description": "Number of mobile devices associated with this Sync account. Recorded each time Sync successfully completes the 'clients' engine."
   },
   "CONTENT_DOCUMENTS_DESTROYED": {
     "record_in_processes": ["main", "content"],
     "expires_in_version": "never",
     "kind": "count",
+    "releaseChannelCollection": "opt-out",
+    "bug_numbers": [1204994, 1569672],
+    "alert_emails": ["tdsmith@mozilla.com", "compatibility@lists.mozilla.org"],
     "description": "Number of content documents destroyed; used in conjunction with use counter histograms"
   },
   "TOP_LEVEL_CONTENT_DOCUMENTS_DESTROYED": {
     "record_in_processes": ["main", "content"],
     "expires_in_version": "never",
     "kind": "count",
+    "releaseChannelCollection": "opt-out",
+    "bug_numbers": [1204994, 1569672],
+    "alert_emails": ["tdsmith@mozilla.com", "compatibility@lists.mozilla.org"],
     "description": "Number of top-level content documents destroyed; used in conjunction with use counter histograms"
   },
   "PUSH_API_NOTIFY": {
     "record_in_processes": ["main", "content"],
     "releaseChannelCollection": "opt-out",
     "alert_emails": ["push@mozilla.com"],
     "bug_numbers": [1429286],
     "expires_in_version": "never",
--- a/toolkit/components/telemetry/histogram-whitelists.json
+++ b/toolkit/components/telemetry/histogram-whitelists.json
@@ -86,17 +86,16 @@
     "CANVAS_2D_USED",
     "CANVAS_WEBGL_USED",
     "CERT_CHAIN_KEY_SIZE_STATUS",
     "CERT_CHAIN_SHA1_POLICY_STATUS",
     "CHANGES_OF_DETECTED_LANGUAGE",
     "CHANGES_OF_TARGET_LANGUAGE",
     "CHECK_ADDONS_MODIFIED_MS",
     "COMPONENTS_SHIM_ACCESSED_BY_CONTENT",
-    "CONTENT_DOCUMENTS_DESTROYED",
     "CRASH_STORE_COMPRESSED_BYTES",
     "DATABASE_LOCKED_EXCEPTION",
     "DATABASE_SUCCESSFUL_UNLOCK",
     "DATA_STORAGE_ENTRIES",
     "DEFECTIVE_PERMISSIONS_SQL_REMOVED",
     "DEFERRED_FINALIZE_ASYNC",
     "DENIED_TRANSLATION_OFFERS",
     "DEVTOOLS_DEBUGGER_DISPLAY_SOURCE_LOCAL_MS",
@@ -426,17 +425,16 @@
     "SYSTEM_FONT_FALLBACK_FIRST",
     "SYSTEM_FONT_FALLBACK_SCRIPT",
     "TAP_TO_LOAD_ENABLED",
     "TAP_TO_LOAD_IMAGE_SIZE",
     "THUNDERBIRD_CONVERSATIONS_TIME_TO_2ND_GLODA_QUERY_MS",
     "THUNDERBIRD_GLODA_SIZE_MB",
     "THUNDERBIRD_INDEXING_RATE_MSG_PER_S",
     "TLS_ERROR_REPORT_UI",
-    "TOP_LEVEL_CONTENT_DOCUMENTS_DESTROYED",
     "TRANSLATED_CHARACTERS",
     "TRANSLATED_PAGES",
     "TRANSLATED_PAGES_BY_LANGUAGE",
     "TRANSLATION_OPPORTUNITIES",
     "TRANSLATION_OPPORTUNITIES_BY_LANGUAGE",
     "WEAVE_COMPLETE_SUCCESS_COUNT",
     "WEAVE_CONFIGURED",
     "WEAVE_CONFIGURED_MASTER_PASSWORD",
@@ -555,17 +553,16 @@
     "CERT_VALIDATION_HTTP_REQUEST_FAILED_TIME",
     "CERT_VALIDATION_HTTP_REQUEST_RESULT",
     "CERT_VALIDATION_HTTP_REQUEST_SUCCEEDED_TIME",
     "CHANGES_OF_DETECTED_LANGUAGE",
     "CHANGES_OF_TARGET_LANGUAGE",
     "CHECK_ADDONS_MODIFIED_MS",
     "COMPONENTS_SHIM_ACCESSED_BY_CONTENT",
     "COMPOSITE_FRAME_ROUNDTRIP_TIME",
-    "CONTENT_DOCUMENTS_DESTROYED",
     "COOKIE_SCHEME_SECURITY",
     "CRASH_STORE_COMPRESSED_BYTES",
     "CYCLE_COLLECTOR",
     "CYCLE_COLLECTOR_ASYNC_SNOW_WHITE_FREEING",
     "CYCLE_COLLECTOR_COLLECTED",
     "CYCLE_COLLECTOR_FINISH_IGC",
     "CYCLE_COLLECTOR_FULL",
     "CYCLE_COLLECTOR_NEED_GC",
@@ -1082,17 +1079,16 @@
     "TELEMETRY_TEST_KEYED_RELEASE_OPTIN",
     "TELEMETRY_TEST_KEYED_RELEASE_OPTOUT",
     "TELEMETRY_TEST_RELEASE_OPTIN",
     "TELEMETRY_TEST_RELEASE_OPTOUT",
     "THUNDERBIRD_CONVERSATIONS_TIME_TO_2ND_GLODA_QUERY_MS",
     "THUNDERBIRD_GLODA_SIZE_MB",
     "THUNDERBIRD_INDEXING_RATE_MSG_PER_S",
     "TLS_ERROR_REPORT_UI",
-    "TOP_LEVEL_CONTENT_DOCUMENTS_DESTROYED",
     "TOTAL_CONTENT_PAGE_LOAD_TIME",
     "TOTAL_COUNT_HIGH_ERRORS",
     "TOTAL_COUNT_LOW_ERRORS",
     "TRANSACTION_WAIT_TIME_HTTP",
     "TRANSACTION_WAIT_TIME_SPDY",
     "TRANSLATED_CHARACTERS",
     "TRANSLATED_PAGES",
     "TRANSLATED_PAGES_BY_LANGUAGE",