Bug 1528752: Remove unused "unboxed" member from MElements. r=mgaudet
authorAndré Bargull <andre.bargull@gmail.com>
Mon, 18 Feb 2019 06:19:59 -0800
changeset 522522 7eb6431fcc65e7baf25e9bb6a1bf18e9c5e90cdf
parent 522521 4339eeddc19dde44ebd77022a8df74cb41377d6b
child 522523 8cd8d6fd4931766ac24ca6248b78520607acd7ed
push id2032
push userffxbld-merge
push dateMon, 13 May 2019 09:36:57 +0000
treeherdermozilla-release@455c1065dcbe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmgaudet
bugs1528752
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1528752: Remove unused "unboxed" member from MElements. r=mgaudet
js/src/jit/IonBuilder.cpp
js/src/jit/MIR.h
--- a/js/src/jit/IonBuilder.cpp
+++ b/js/src/jit/IonBuilder.cpp
@@ -14250,17 +14250,17 @@ MInstruction* IonBuilder::initializedLen
   return res;
 }
 
 MInstruction* IonBuilder::setInitializedLength(MDefinition* obj, size_t count) {
   MOZ_ASSERT(count);
 
   // MSetInitializedLength takes the index of the last element, rather
   // than the count itself.
-  MInstruction* elements = MElements::New(alloc(), obj, /* unboxed = */ false);
+  MInstruction* elements = MElements::New(alloc(), obj);
   current->add(elements);
   MInstruction* res = MSetInitializedLength::New(
       alloc(), elements, constant(Int32Value(count - 1)));
   current->add(res);
   return res;
 }
 
 MDefinition* IonBuilder::getCallee() {
--- a/js/src/jit/MIR.h
+++ b/js/src/jit/MIR.h
@@ -6927,33 +6927,29 @@ class MSlots : public MUnaryInstruction,
     return AliasSet::Load(AliasSet::ObjectFields);
   }
 
   ALLOW_CLONE(MSlots)
 };
 
 // Returns obj->elements.
 class MElements : public MUnaryInstruction, public SingleObjectPolicy::Data {
-  bool unboxed_;
-
-  explicit MElements(MDefinition* object, bool unboxed = false)
-      : MUnaryInstruction(classOpcode, object), unboxed_(unboxed) {
+  explicit MElements(MDefinition* object)
+      : MUnaryInstruction(classOpcode, object) {
     setResultType(MIRType::Elements);
     setMovable();
   }
 
  public:
   INSTRUCTION_HEADER(Elements)
   TRIVIAL_NEW_WRAPPERS
   NAMED_OPERANDS((0, object))
 
-  bool unboxed() const { return unboxed_; }
-  bool congruentTo(const MDefinition* ins) const override {
-    return congruentIfOperandsEqual(ins) &&
-           ins->toElements()->unboxed() == unboxed();
+  bool congruentTo(const MDefinition* ins) const override {
+    return congruentIfOperandsEqual(ins);
   }
   AliasSet getAliasSet() const override {
     return AliasSet::Load(AliasSet::ObjectFields);
   }
 
   ALLOW_CLONE(MElements)
 };