Bug 1415182. Make the External interface [NoInterfaceObject], per spec. r=qdot
authorBoris Zbarsky <bzbarsky@mit.edu>
Wed, 08 Nov 2017 00:25:55 -0500
changeset 443967 7e7144bcdcb5b8ea1a7ff362b4ebe9953b8a16a6
parent 443966 73352624f35c23e6000cd50d095708d69249f35d
child 443968 8a46aeb0b562dd2ac240657a53f489046deb9acb
push id1618
push userCallek@gmail.com
push dateThu, 11 Jan 2018 17:45:48 +0000
treeherdermozilla-release@882ca853e05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersqdot
bugs1415182
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1415182. Make the External interface [NoInterfaceObject], per spec. r=qdot MozReview-Commit-ID: DCX4uxAFPAu
dom/tests/mochitest/general/test_interfaces.js
dom/webidl/External.webidl
--- a/dom/tests/mochitest/general/test_interfaces.js
+++ b/dom/tests/mochitest/general/test_interfaces.js
@@ -338,18 +338,16 @@ var interfaceNamesInGlobalScope =
     "ErrorEvent",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "Event",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "EventSource",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "EventTarget",
 // IMPORTANT: Do not change this list without review from a DOM peer!
-    "External",
-// IMPORTANT: Do not change this list without review from a DOM peer!
     "File",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "FileList",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "FileReader",
 // IMPORTANT: Do not change this list without review from a DOM peer!
     "FileSystem",
 // IMPORTANT: Do not change this list without review from a DOM peer!
--- a/dom/webidl/External.webidl
+++ b/dom/webidl/External.webidl
@@ -1,15 +1,15 @@
 /* -*- Mode: IDL; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-[JSImplementation="@mozilla.org/sidebar;1"]
+[NoInterfaceObject, JSImplementation="@mozilla.org/sidebar;1"]
 interface External
 {
   [UnsafeInPrerendering] void AddSearchProvider(DOMString aDescriptionURL);
   unsigned long IsSearchProviderInstalled(DOMString aSearchURL);
 };
 
 // Mozilla extension
 partial interface External {