Bug 1563695 - Do not close SpdyConnectTransaction in TLSFilterTransaction. r=mayhemer
authorDragana Damjanovic <dd.mozilla@gmail.com>
Fri, 05 Jul 2019 18:54:34 +0000
changeset 544329 7d95f38f8dada3b12f299d9fe36822e8dacb6d1e
parent 544328 477989aa5e6439946b2addd0c6b3e1f328979db2
child 544330 1373ded9ebd53354a69d8637f4c34b3abe89df19
push id2131
push userffxbld-merge
push dateMon, 26 Aug 2019 18:30:20 +0000
treeherdermozilla-release@b19ffb3ca153 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmayhemer
bugs1563695
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1563695 - Do not close SpdyConnectTransaction in TLSFilterTransaction. r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D37048
netwerk/protocol/http/TunnelUtils.cpp
--- a/netwerk/protocol/http/TunnelUtils.cpp
+++ b/netwerk/protocol/http/TunnelUtils.cpp
@@ -125,28 +125,16 @@ void TLSFilterTransaction::Close(nsresul
   }
 
   if (mTimer) {
     mTimer->Cancel();
     mTimer = nullptr;
   }
   mTransaction->Close(aReason);
   mTransaction = nullptr;
-
-  RefPtr<NullHttpTransaction> baseTrans(do_QueryReferent(mWeakTrans));
-  SpdyConnectTransaction* trans =
-      baseTrans ? baseTrans->QuerySpdyConnectTransaction() : nullptr;
-
-  LOG(("TLSFilterTransaction::Close %p aReason=%" PRIx32 " trans=%p\n", this,
-       static_cast<uint32_t>(aReason), trans));
-
-  if (trans) {
-    trans->Close(aReason);
-    trans = nullptr;
-  }
 }
 
 nsresult TLSFilterTransaction::OnReadSegment(const char* aData, uint32_t aCount,
                                              uint32_t* outCountRead) {
   LOG(("TLSFilterTransaction %p OnReadSegment %d (buffered %d)\n", this, aCount,
        mEncryptedTextUsed));
 
   mReadSegmentReturnValue = NS_OK;