Bug 1484741 - Fixing bookmarklet keywords from loading in a new tab. r=Gijs
authorJonathan Kingston <jkt@mozilla.com>
Thu, 11 Oct 2018 07:36:01 +0000
changeset 499186 7d8d3fc3e9f433e4aa967341a5f7ac649191b044
parent 499185 3a7632140ea5c04fed23b206f3dacf8e83719e86
child 499187 172e411269552064ec3531a25623c9d402701a6f
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1484741
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1484741 - Fixing bookmarklet keywords from loading in a new tab. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D4917
browser/base/content/urlbarBindings.xml
--- a/browser/base/content/urlbarBindings.xml
+++ b/browser/base/content/urlbarBindings.xml
@@ -840,21 +840,21 @@ file, You can obtain one at http://mozil
             postData,
             allowThirdPartyFixup: true,
             triggeringPrincipal,
           };
           if (openUILinkWhere == "current") {
             params.targetBrowser = browser;
             params.indicateErrorPageLoad = true;
             params.allowPinnedTabHostChange = true;
-            params.allowInheritPrincipal = mayInheritPrincipal;
             params.allowPopups = url.startsWith("javascript:");
           } else {
             params.initiatingDoc = document;
           }
+          params.allowInheritPrincipal = mayInheritPrincipal;
 
           if (openUILinkParams) {
             for (let key in openUILinkParams) {
               params[key] = openUILinkParams[key];
             }
           }
 
           // Focus the content area before triggering loads, since if the load