Bug 1369305 - Do not show a tooltip for the button will not open sub-dialog. r=mconley
authorEvan Tseng <evan@tseng.io>
Fri, 02 Jun 2017 16:26:58 +0800
changeset 412712 7d5df2dead2c9edaa41688a82d9d9dcc86529ef2
parent 412711 b16a3c81c33981da108dbe259dfcc93d3b705113
child 412747 275588f4d852d7dc183a9dcc70a311413dc7a063
child 412749 2839baa84dca69d6691fa3c81b450431c01f05c9
push id1490
push usermtabara@mozilla.com
push dateMon, 31 Jul 2017 14:08:16 +0000
treeherdermozilla-release@70e32e6bf15e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley
bugs1369305
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1369305 - Do not show a tooltip for the button will not open sub-dialog. r=mconley MozReview-Commit-ID: 27bnOCJrhRI
browser/components/preferences/in-content-new/findInPage.js
--- a/browser/components/preferences/in-content-new/findInPage.js
+++ b/browser/components/preferences/in-content-new/findInPage.js
@@ -287,29 +287,19 @@ var gSearchResultsPane = {
       }
 
       // Access key are presented
       let complexTextNodesResult = this.highlightMatches(accessKeyTextNodes, nodeSizes, allNodeText.toLowerCase(), searchPhrase);
 
       // Searching some elements, such as xul:button, have a 'label' attribute that contains the user-visible text.
       let labelResult = this.stringMatchesFilters(nodeObject.getAttribute("label"), searchPhrase);
 
-      // Creating tooltips for buttons
-      if (labelResult && nodeObject.tagName === "button") {
-        this.listSearchTooltips.push(nodeObject);
-      }
-
       // Searching some elements, such as xul:label, store their user-visible text in a "value" attribute.
       let valueResult = this.stringMatchesFilters(nodeObject.getAttribute("value"), searchPhrase);
 
-      // Creating tooltips for buttons
-      if (valueResult && nodeObject.tagName === "button") {
-        this.listSearchTooltips.push(nodeObject);
-      }
-
       // Searching some elements, such as xul:button, buttons to open subdialogs.
       let keywordsResult = this.stringMatchesFilters(nodeObject.getAttribute("searchkeywords"), searchPhrase);
 
       // Creating tooltips for buttons
       if (keywordsResult && nodeObject.tagName === "button") {
         this.listSearchTooltips.push(nodeObject);
       }