Bug 1203137 - Tabs tray (Grid): Explicitly disable fading edge. r=margaret
authorSebastian Kaspari <s.kaspari@gmail.com>
Fri, 23 Oct 2015 17:14:33 +0200
changeset 304495 7bcb0cb94a24f8cb245c24b2d7c1fd56a7fa873a
parent 304494 4169913a206bbde202bd75c8729879885ad66b1d
child 304496 c5b8d410813360d376676fb3ab72d93bd7f1b0c4
push id1001
push userraliiev@mozilla.com
push dateMon, 18 Jan 2016 19:06:03 +0000
treeherdermozilla-release@8b89261f3ac4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmargaret
bugs1203137
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1203137 - Tabs tray (Grid): Explicitly disable fading edge. r=margaret On newer devices there's no fading edge but on Gingerbread you can see an ugly, misplaced fading edge effect.
mobile/android/base/tabs/TabsGridLayout.java
--- a/mobile/android/base/tabs/TabsGridLayout.java
+++ b/mobile/android/base/tabs/TabsGridLayout.java
@@ -82,16 +82,18 @@ class TabsGridLayout extends GridView
                 item.setThumbnail(null);
             }
         });
 
         // The clipToPadding setting in the styles.xml doesn't seem to be working (bug 1101784)
         // so lets set it manually in code for the moment as it's needed for the padding animation
         setClipToPadding(false);
 
+        setVerticalFadingEdgeEnabled(false);
+
         final Resources resources = getResources();
         columnWidth = resources.getDimensionPixelSize(R.dimen.tab_panel_column_width);
 
         final int padding = resources.getDimensionPixelSize(R.dimen.tab_panel_grid_padding);
         final int paddingTop = resources.getDimensionPixelSize(R.dimen.tab_panel_grid_padding_top);
 
         // Lets set double the top padding on the bottom so that the last row shows up properly!
         // Your demise, GridView, cannot come fast enough.