Bug 1472740 - Warn on deprecated static theme LWT aliases usage. r=ntim,jaws
authorLuca Greco <lgreco@mozilla.com>
Fri, 23 Nov 2018 18:58:45 +0000
changeset 507969 7b5c486601e568aaa8538d7286dc3bd8be84ad8a
parent 507968 e6fa8908256b2de05afea8cbc841ecfee8756114
child 507970 5ad19f2159391c4299c6b665794068e7567f38e3
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersntim, jaws
bugs1472740
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1472740 - Warn on deprecated static theme LWT aliases usage. r=ntim,jaws This patch doesn't currently prevent a static theme which uses the LWT aliases from being installed successfully but, as the first step for their deprecation and removal, it starts to log a warning message when these aliases are being used (e.g. when installing the static theme extension from "about:debugging", these warnings are being shown to the theme author). A similar linting warning is going to be emitted on AMO submissions (See https://github.com/mozilla/addons-linter/issues/2259), and it will be turned it into a linting error once AMO should start to prevent new static theme submittions from using the LWT aliases. Differential Revision: https://phabricator.services.mozilla.com/D12297
toolkit/components/extensions/schemas/theme.json
--- a/toolkit/components/extensions/schemas/theme.json
+++ b/toolkit/components/extensions/schemas/theme.json
@@ -83,17 +83,18 @@
               "additional_backgrounds": {
                 "type": "array",
                 "items": { "$ref": "ImageDataOrExtensionURL" },
                 "maxItems": 15,
                 "optional": true
               },
               "headerURL": {
                 "$ref": "ImageDataOrExtensionURL",
-                "optional": true
+                "optional": true,
+                "deprecated": "Please use <em>theme.images.theme_frame</em>, this alias will be removed in Firefox 69."
               },
               "theme_frame": {
                 "$ref": "ImageDataOrExtensionURL",
                 "optional": true
               }
             },
             "additionalProperties": { "$ref": "ImageDataOrExtensionURL" }
           },
@@ -102,29 +103,31 @@
             "optional": true,
             "properties": {
               "tab_selected": {
                 "$ref": "ThemeColor",
                 "optional": true
               },
               "accentcolor": {
                 "$ref": "ThemeColor",
-                "optional": true
+                "optional": true,
+                "deprecated": "Please use <em>theme.colors.frame</em>, this alias will be removed in Firefox 69."
               },
               "frame": {
                 "$ref": "ThemeColor",
                 "optional": true
               },
               "frame_inactive": {
                 "$ref": "ThemeColor",
                 "optional": true
               },
               "textcolor": {
                 "$ref": "ThemeColor",
-                "optional": true
+                "optional": true,
+                "deprecated": "Please use <em>theme.colors.tab_background_text</em>, this alias will be removed in Firefox 69."
               },
               "tab_background_text": {
                 "$ref": "ThemeColor",
                 "optional": true
               },
               "tab_background_separator": {
                 "$ref": "ThemeColor",
                 "optional": true
@@ -142,17 +145,18 @@
                 "optional": true
               },
               "toolbar": {
                 "$ref": "ThemeColor",
                 "optional": true
               },
               "toolbar_text": {
                 "$ref": "ThemeColor",
-                "optional": true
+                "optional": true,
+                "deprecated": "Please use <em>theme.colors.bookmark_text</em>, this alias will be removed in Firefox 69."
               },
               "bookmark_text": {
                 "$ref": "ThemeColor",
                 "optional": true
               },
               "toolbar_field": {
                 "$ref": "ThemeColor",
                 "optional": true