Bug 1342385: Allow mremap on linux32 for wasm; r=jld
authorBenjamin Bouvier <benj@benj.me>
Fri, 24 Feb 2017 13:18:57 +0100
changeset 394039 7a9b07064c28ac88d837c14e3cc85e95a8597aa9
parent 394038 35a06336b3be69ef131511176334279e3187191c
child 394040 06254f3037c370bfa81a26c4a5ff673c8e16940f
push id1468
push userasasaki@mozilla.com
push dateMon, 05 Jun 2017 19:31:07 +0000
treeherdermozilla-release@0641fc6ee9d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjld
bugs1342385
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1342385: Allow mremap on linux32 for wasm; r=jld MozReview-Commit-ID: 82f8ryvd57S
security/sandbox/linux/SandboxFilter.cpp
testing/web-platform/mozilla/meta/wasm/nop.wast.js.html.ini
testing/web-platform/mozilla/meta/wasm/resizing.wast.js.html.ini
--- a/security/sandbox/linux/SandboxFilter.cpp
+++ b/security/sandbox/linux/SandboxFilter.cpp
@@ -691,20 +691,18 @@ public:
       // Some fcntls have significant side effects like sending
       // arbitrary signals, and there's probably nontrivial kernel
       // attack surface; this should be locked down more if possible.
       return Allow();
 
     case __NR_mprotect:
     case __NR_brk:
     case __NR_madvise:
-#if !defined(MOZ_MEMORY)
-      // libc's realloc uses mremap (Bug 1286119).
+      // libc's realloc uses mremap (Bug 1286119); wasm does too (bug 1342385).
     case __NR_mremap:
-#endif
       return Allow();
 
     case __NR_sigaltstack:
       return Allow();
 
 #ifdef __NR_set_thread_area
     case __NR_set_thread_area:
       return Allow();
deleted file mode 100644
--- a/testing/web-platform/mozilla/meta/wasm/nop.wast.js.html.ini
+++ /dev/null
@@ -1,3 +0,0 @@
-[nop.wast.js.html]
-  disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1342385
-  type: testharness
deleted file mode 100644
--- a/testing/web-platform/mozilla/meta/wasm/resizing.wast.js.html.ini
+++ /dev/null
@@ -1,3 +0,0 @@
-[resizing.wast.js.html]
-  disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1342385
-  type: testharness