Bug 1493071 Rename bouncer_check cron task r=mtabara a=release
authorSimon Fraser <sfraser@mozilla.com>
Mon, 24 Sep 2018 16:01:45 +0000
changeset 492744 7a94cbe00b3355a553bb11914a3691881a18a971
parent 492743 7c608659a5efe64710a8334945213961289b7b81
child 492745 fb5111a3fc510f6dd0c4953e913a7aa5e84849aa
push id1815
push userffxbld-merge
push dateMon, 15 Oct 2018 10:40:45 +0000
treeherdermozilla-release@18d4c09e9378 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmtabara, release
bugs1493071
milestone63.0
Bug 1493071 Rename bouncer_check cron task r=mtabara a=release Differential Revision: https://phabricator.services.mozilla.com/D6660
.cron.yml
taskcluster/ci/bouncer-check/kind.yml
taskcluster/ci/cron-bouncer-check/kind.yml
taskcluster/docs/kinds.rst
taskcluster/taskgraph/target_tasks.py
taskcluster/taskgraph/transforms/bouncer_check.py
--- a/.cron.yml
+++ b/.cron.yml
@@ -101,17 +101,17 @@ jobs:
           by-project:
               mozilla-central: [{hour: 10, minute: 30}]
               # No default
 
     - name: bouncer-check
       job:
           type: decision-task
           treeherder-symbol: Rel
-          target-tasks-method: bouncer_check
+          target-tasks-method: cron_bouncer_check
       run-on-projects:
           - mozilla-beta
           - mozilla-release
       when:
           by-project:
               # No default branch
               mozilla-beta:
                   - {hour: 7, minute: 0}
rename from taskcluster/ci/bouncer-check/kind.yml
rename to taskcluster/ci/cron-bouncer-check/kind.yml
--- a/taskcluster/ci/bouncer-check/kind.yml
+++ b/taskcluster/ci/cron-bouncer-check/kind.yml
@@ -8,17 +8,16 @@ transforms:
     - taskgraph.transforms.bouncer_check:transforms
     - taskgraph.transforms.job:transforms
     - taskgraph.transforms.task:transforms
 
 job-defaults:
     name: bouncer-check
     description: bouncer check
     run-on-projects: []  # to make sure this never runs as part of CI
-    shipping-phase: push
     worker-type: aws-provisioner-v1/gecko-{level}-b-linux
     worker:
         max-run-time: 1200
         docker-image: {in-tree: "update-verify"}
     run:
         using: run-task
         sparse-profile: mozharness
     attributes:
--- a/taskcluster/docs/kinds.rst
+++ b/taskcluster/docs/kinds.rst
@@ -306,18 +306,18 @@ Marks releases as shipped in Ship-It v1
 release-mark-as-started
 -----------------------
 Marks releases as started in Ship-It v1
 
 release-bouncer-aliases
 -----------------------
 Update Bouncer's (download.mozilla.org) "latest" aliases.
 
-bouncer-check
--------------
+cron-bouncer-check
+------------------
 Checks Bouncer (download.mozilla.org) uptake.
 
 release-bouncer-check
 ---------------------
 Checks Bouncer (download.mozilla.org) uptake as part of the release tasks.
 
 release-generate-checksums
 --------------------------
--- a/taskcluster/taskgraph/target_tasks.py
+++ b/taskcluster/taskgraph/target_tasks.py
@@ -587,16 +587,16 @@ def target_tasks_file_update(full_task_g
     """Select the set of tasks required to perform nightly in-tree file updates
     """
     def filter(task):
         # For now any task in the repo-update kind is ok
         return task.kind in ['repo-update']
     return [l for l, t in full_task_graph.tasks.iteritems() if filter(t)]
 
 
-@_target_task('bouncer_check')
+@_target_task('cron_bouncer_check')
 def target_tasks_bouncer_check(full_task_graph, parameters, graph_config):
     """Select the set of tasks required to perform bouncer version verification.
     """
     def filter(task):
         # For now any task in the repo-update kind is ok
-        return task.kind in ['bouncer-check']
+        return task.kind in ['cron-bouncer-check']
     return [l for l, t in full_task_graph.tasks.iteritems() if filter(t)]
--- a/taskcluster/taskgraph/transforms/bouncer_check.py
+++ b/taskcluster/taskgraph/transforms/bouncer_check.py
@@ -65,17 +65,17 @@ def handle_keyed_by(config, jobs):
         job = copy.deepcopy(job)  # don't overwrite dict values here
         for field in fields:
             resolve_keyed_by(item=job, field=field, item_name=job['name'],
                              project=config.params['project'])
 
         for cfg in job["run"]["config"]:
             job["run"]["command"].extend(["--config", cfg])
 
-        if config.kind == "bouncer-check":
+        if config.kind == "cron-bouncer-check":
             job["run"]["command"].extend([
                 "--product-field={}".format(job["run"]["product-field"]),
                 "--products-url={}".format(job["run"]["products-url"]),
             ])
             del job["run"]["product-field"]
             del job["run"]["products-url"]
         elif config.kind == "release-bouncer-check":
             job["run"]["command"].append("--version={}".format(version))