Bug 1037079 - [B2G][Clock] Fix alarms and timer alerts. r=bz
☠☠ backed out by 195449572272 ☠ ☠
authorSean Lin <selin@mozilla.com>
Mon, 14 Jul 2014 10:46:09 +0800
changeset 216363 7a3c1d05d492e79df0c7e4b145e54a71098178d1
parent 216362 5098feb565e6084e28525a6e5daea6da0219bf3e
child 216364 c1ec5c6d584e93392efeb2bd50b3d4a5221d2dd3
push id515
push userraliiev@mozilla.com
push dateMon, 06 Oct 2014 12:51:51 +0000
treeherdermozilla-release@267c7a481bef [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz
bugs1037079
milestone33.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1037079 - [B2G][Clock] Fix alarms and timer alerts. r=bz
dom/alarm/AlarmsManager.js
dom/alarm/test/mochitest.ini
dom/alarm/test/test_bug1037079.html
--- a/dom/alarm/AlarmsManager.js
+++ b/dom/alarm/AlarmsManager.js
@@ -56,25 +56,28 @@ AlarmsManager.prototype = {
         isIgnoreTimezone = true;
         break;
 
       default:
         throw Components.results.NS_ERROR_INVALID_ARG;
         break;
     }
 
+    // Run JSON.stringify() in the sand box with the principal of the calling
+    // web page to ensure no cross-origin object is involved. A "Permission
+    // Denied" error will be thrown in case of privilege violation.
     let sandbox = new Cu.Sandbox(Cu.getWebIDLCallerPrincipal());
     sandbox.data = aData;
     let data = Cu.evalInSandbox("JSON.stringify(data)", sandbox);
     let request = this.createRequest();
     this._cpmm.sendAsyncMessage("AlarmsManager:Add",
                                 { requestId: this.getRequestId(request),
                                   date: aDate,
                                   ignoreTimezone: isIgnoreTimezone,
-                                  data: data,
+                                  data: JSON.parse(data),
                                   pageURL: this._pageURL,
                                   manifestURL: this._manifestURL });
     return request;
   },
 
   remove: function remove(aId) {
     debug("remove()");
 
@@ -107,26 +110,23 @@ AlarmsManager.prototype = {
       case "AlarmsManager:Add:Return:OK":
         Services.DOMRequest.fireSuccess(request, json.id);
         break;
 
       case "AlarmsManager:GetAll:Return:OK":
         // We don't need to expose everything to the web content.
         let alarms = [];
         json.alarms.forEach(function trimAlarmInfo(aAlarm) {
-          let sandbox = new Cu.Sandbox(this._principal);
-          sandbox.data = aAlarm.data;
-          let data = Cu.evalInSandbox("JSON.parse(data)", sandbox);
           let alarm = { "id": aAlarm.id,
                         "date": aAlarm.date,
                         "respectTimezone": aAlarm.ignoreTimezone ?
                                              "ignoreTimezone" : "honorTimezone",
-                        "data": data };
+                        "data": aAlarm.data };
           alarms.push(alarm);
-        }.bind(this));
+        });
 
         Services.DOMRequest.fireSuccess(request,
                                         Cu.cloneInto(alarms, this._window));
         break;
 
       case "AlarmsManager:Add:Return:KO":
         Services.DOMRequest.fireError(request, json.errorMsg);
         break;
@@ -154,21 +154,20 @@ AlarmsManager.prototype = {
     this.initDOMRequestHelper(aWindow, ["AlarmsManager:Add:Return:OK",
                                         "AlarmsManager:Add:Return:KO",
                                         "AlarmsManager:GetAll:Return:OK",
                                         "AlarmsManager:GetAll:Return:KO"]);
 
     // Get the manifest URL if this is an installed app
     let appsService = Cc["@mozilla.org/AppsService;1"]
                         .getService(Ci.nsIAppsService);
+    let principal = aWindow.document.nodePrincipal;
+    this._pageURL = principal.URI.spec;
+    this._manifestURL = appsService.getManifestURLByLocalId(principal.appId);
     this._window = aWindow;
-    this._principal = this._window.document.nodePrincipal;
-    this._pageURL = this._principal.URI.spec;
-    this._manifestURL =
-      appsService.getManifestURLByLocalId(this._principal.appId);
   },
 
   // Called from DOMRequestIpcHelper.
   uninit: function uninit() {
     debug("uninit()");
   },
 }
 
--- a/dom/alarm/test/mochitest.ini
+++ b/dom/alarm/test/mochitest.ini
@@ -11,8 +11,10 @@ skip-if = (buildapp == 'b2g' && toolkit 
 [test_alarm_add_respectTimezone.html]
 skip-if = (buildapp == 'b2g' && toolkit != 'gonk') #Bug 931116, b2g desktop specific, initial triage
 [test_alarm_non_permitted_app.html]
 [test_alarm_permitted_app.html]
 [test_alarm_remove.html]
 skip-if = (buildapp == 'b2g' && toolkit != 'gonk') #Bug 931116, b2g desktop specific, initial triage
 [test_bug1015540.html]
 skip-if = (buildapp == 'b2g' && toolkit != 'gonk') #Bug 931116, b2g desktop specific, initial triage
+[test_bug1037079.html]
+skip-if = (buildapp == 'b2g' && toolkit != 'gonk') #Bug 931116, b2g desktop specific, initial triage
new file mode 100644
--- /dev/null
+++ b/dom/alarm/test/test_bug1037079.html
@@ -0,0 +1,91 @@
+<!DOCTYPE HTML>
+<html>
+<head>
+  <meta charset="utf-8">
+  <title>Test time alert is fired for Bug 1037079</title>
+  <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
+  <script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
+</head>
+<body>
+<p id="display"></p>
+<div id="content" style="display: none"></div>
+<pre id="test">
+  <script type="application/javascript">
+
+  "use strict";
+
+  function testFireTimeAlert() {
+    var secondsLater = new Date();
+    secondsLater.setSeconds(secondsLater.getSeconds() + 10);
+
+    var domRequest;
+    try {
+      // Set system message handler.
+      navigator.mozSetMessageHandler('alarm', function(message){
+        ok(true, "Time alert has been fired.");
+        SimpleTest.finish();
+      });
+
+      domRequest = navigator.mozAlarms.add(secondsLater, "honorTimezone",
+    		                               {type: "timer"});
+    } catch (e) {
+      ok(false, "Unexpected exception trying to set time alert.");
+
+      return SimpleTest.finish();
+    }
+    domRequest.onsuccess = function(e) {
+      ok(true, "Set time alert. Waiting to be fired.");
+    };
+    domRequest.onerror = function(e) {
+      ok(false, "Unable to set time alert.");
+
+      SimpleTest.finish();
+    };
+  }
+
+  function startTests() {
+    SpecialPowers.pushPrefEnv({
+      "set": [["dom.mozAlarms.enabled", true]]
+    }, function() {
+      var isAllowedToTest = true;
+
+      if (navigator.appVersion.indexOf("Android") !== -1) {
+        ok(true, "mozAlarms is not allowed on Android for now. " +
+                 "TODO Bug 863557.");
+        isAllowedToTest = false;
+      } else if (SpecialPowers.wrap(document).nodePrincipal.appStatus ==
+                 SpecialPowers.Ci.nsIPrincipal.APP_STATUS_NOT_INSTALLED) {
+        ok(true, "mozAlarms is not allowed for non-installed apps. " +
+                 "TODO Bug 876981.");
+        isAllowedToTest = false;
+      }
+
+      if (isAllowedToTest) {
+        ok(true, "Start to test...");
+        testFireTimeAlert();
+      } else {
+        // A sanity check to make sure we must run tests on Firefox OS (B2G).
+        if (navigator.userAgent.indexOf("Mobile") != -1 &&
+            navigator.appVersion.indexOf("Android") == -1) {
+          ok(false, "Should run the test on Firefox OS (B2G)!");
+        }
+
+        SimpleTest.finish();
+      }
+    });
+  }
+
+  SimpleTest.expectAssertions(0, 9);
+  SimpleTest.waitForExplicitFinish();
+  if (SpecialPowers.hasPermission("alarms", document)) {
+    startTests();
+  } else {
+    // Add the permissions and reload so they propogate
+    SpecialPowers.addPermission("alarms", true, document);
+    window.location.reload();
+  }
+
+  </script>
+</pre>
+</body>
+</html>