Bug 1422380 - move --enable-jitspew to moz.configure; r=nalexander
authorNathan Froyd <froydnj@mozilla.com>
Sat, 02 Dec 2017 13:43:40 -0500
changeset 448870 799ed2f23d7d72c2b444ff67848a4cf03277d1d8
parent 448869 9e92a30a9d52cc455f15b16c1b872d151c592ea4
child 448871 de1f7a92e8726bdd365d4bbc5e65eaa369fbc20a
child 448872 1815a9a4c8d56abc94aa46e44fdf7d333168b5a4
push id1648
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 12:45:47 +0000
treeherdermozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander
bugs1422380
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1422380 - move --enable-jitspew to moz.configure; r=nalexander
build/moz.configure/old.configure
js/moz.configure
js/src/old-configure.in
--- a/build/moz.configure/old.configure
+++ b/build/moz.configure/old.configure
@@ -187,17 +187,16 @@ def old_configure_options(*options):
     '--enable-feeds',
     '--enable-gamepad',
     '--enable-gconf',
     '--enable-gczeal',
     '--enable-hardware-aec-ns',
     '--enable-icf',
     '--enable-install-strip',
     '--enable-ios-target',
-    '--enable-jitspew',
     '--enable-libjpeg-turbo',
     '--enable-libproxy',
     '--enable-llvm-hacks',
     '--enable-logrefcnt',
     '--enable-maintenance-service',
     '--enable-memory-sanitizer',
     '--enable-mobile-optimize',
     '--enable-necko-wifi',
--- a/js/moz.configure
+++ b/js/moz.configure
@@ -292,16 +292,26 @@ js_option('--enable-perf', env='JS_ION_P
 @depends('--enable-perf')
 def ion_perf(value):
     if value:
         return True
 
 set_define('JS_ION_PERF', ion_perf)
 
 
+js_option('--enable-jitspew',
+          default=depends(when=moz_debug)(lambda: True),
+          help='Enable the Jit spew and IONFLAGS environment variable.')
+
+set_define('JS_JITSPEW',
+           depends_if('--enable-jitspew')(lambda _: True))
+set_config('JS_JITSPEW',
+           depends_if('--enable-jitspew')(lambda _: True))
+
+
 js_option('--enable-more-deterministic', env='JS_MORE_DETERMINISTIC',
           help='Enable changes that make the shell more deterministic')
 
 @depends('--enable-more-deterministic')
 def more_deterministic(value):
     if value:
         return True
 
--- a/js/src/old-configure.in
+++ b/js/src/old-configure.in
@@ -1542,30 +1542,16 @@ AC_SUBST(MOZ_VALGRIND)
 dnl ========================================================
 dnl instruments
 dnl ========================================================
 if test -n "$MOZ_INSTRUMENTS"; then
     LIBS="$LIBS -framework CoreFoundation"
 fi
 
 dnl ========================================================
-dnl JitSpew.  Enabled by default in debug builds.
-dnl ========================================================
-MOZ_ARG_ENABLE_BOOL(jitspew,
-[  --enable-jitspew        Enable the Jit spew and IONFLAGS.],
-    JS_JITSPEW=1,
-    JS_JITSPEW= )
-
-if test -n "$JS_JITSPEW" -o -n "$MOZ_DEBUG"; then
-    AC_DEFINE(JS_JITSPEW)
-fi
-
-AC_SUBST(JS_JITSPEW)
-
-dnl ========================================================
 dnl Debug (see Bug 939505)
 dnl ========================================================
 if test -n "$MOZ_DEBUG"; then
     AC_DEFINE(JS_DEBUG)
 fi
 
 dnl ========================================================
 dnl Zealous JavaScript GC