Bug 1503393 - Make 'no proxy' field editable r=jaws
☠☠ backed out by 7670b6ce33a4 ☠ ☠
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Mon, 03 Dec 2018 16:27:50 +0200
changeset 508456 7878029aaba609b5433d3eea98873a450cf2cb62
parent 508455 02e383b73c971e656097b3040e9cc523039018d6
child 508457 52e8ef71af9b837be53b294d09381d70c5efceba
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1503393
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1503393 - Make 'no proxy' field editable r=jaws
browser/components/preferences/connection.js
--- a/browser/components/preferences/connection.js
+++ b/browser/components/preferences/connection.js
@@ -123,17 +123,17 @@ var gConnectionsDialog = {
     // Now update the other protocols
     this.updateProtocolPrefs();
 
     var shareProxiesPref = Preferences.get("network.proxy.share_proxy_settings");
     shareProxiesPref.disabled = proxyTypePref.value != 1;
     var autologinProxyPref = Preferences.get("signon.autologin.proxy");
     autologinProxyPref.disabled = proxyTypePref.value == 0;
     var noProxiesPref = Preferences.get("network.proxy.no_proxies_on");
-    noProxiesPref.disabled = proxyTypePref.value != 1;
+    noProxiesPref.disabled = proxyTypePref.value == 0;
 
     var autoconfigURLPref = Preferences.get("network.proxy.autoconfig_url");
     autoconfigURLPref.disabled = proxyTypePref.value != 2;
 
     this.updateReloadButton();
   },
 
   updateDNSPref() {