Bug 1518210 - Wasm: Rename WASM_HUGE_MEMORY to WASM_SUPPORTS_HUGE_MEMORY. r=lth
☠☠ backed out by ea9924171afd ☠ ☠
authorRyan Hunt <rhunt@eqrion.net>
Fri, 30 Aug 2019 02:33:13 +0000
changeset 554550 777aa22c9e8a19fc1df9e575db3b46702805bf23
parent 554549 eb3fbf8bfb2b344b83c483a35f221b61bfcc76e2
child 554551 40e3f38af193cf11426ed48d89780c1768deb05d
push id2165
push userffxbld-merge
push dateMon, 14 Oct 2019 16:30:58 +0000
treeherdermozilla-release@0eae18af659f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslth
bugs1518210
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1518210 - Wasm: Rename WASM_HUGE_MEMORY to WASM_SUPPORTS_HUGE_MEMORY. r=lth To highlight that WASM_HUGE_MEMORY doesn't imply we are using huge memory, this commit renames the #define. Most usages of WASM_HUGE_MEMORY are not updated, as they will be removed in later commits. Differential Revision: https://phabricator.services.mozilla.com/D41867
js/src/js-config.mozbuild
js/src/wasm/WasmTypes.cpp
--- a/js/src/js-config.mozbuild
+++ b/js/src/js-config.mozbuild
@@ -2,17 +2,17 @@
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 # Some huge-mapping optimization instead of bounds checks on supported
 # platforms.
 if CONFIG['JS_CODEGEN_X64'] or CONFIG['JS_CODEGEN_ARM64']:
-    DEFINES['WASM_HUGE_MEMORY'] = True
+    DEFINES['WASM_SUPPORTS_HUGE_MEMORY'] = True
 
 # Enables CACHEIR_LOGS to diagnose IC coverage, and
 # Structured spewer for diagnostics
 if CONFIG['MOZ_DEBUG'] or CONFIG['NIGHTLY_BUILD']:
     DEFINES['JS_CACHEIR_SPEW'] = True
     DEFINES['JS_STRUCTURED_SPEW'] = True
 
 # CTypes
--- a/js/src/wasm/WasmTypes.cpp
+++ b/js/src/wasm/WasmTypes.cpp
@@ -29,19 +29,19 @@
 
 using namespace js;
 using namespace js::jit;
 using namespace js::wasm;
 
 using mozilla::IsPowerOfTwo;
 using mozilla::MakeEnumeratedRange;
 
-// We have only tested WASM_HUGE_MEMORY on x64 and arm64.
+// We have only tested huge memory on x64 and arm64.
 
-#if defined(WASM_HUGE_MEMORY)
+#if defined(WASM_SUPPORTS_HUGE_MEMORY)
 #  if !(defined(JS_CODEGEN_X64) || defined(JS_CODEGEN_ARM64))
 #    error "Not an expected configuration"
 #  endif
 #endif
 
 // More sanity checks.
 
 static_assert(MaxMemoryInitialPages <=