Bug 1328929 - enable no-unsafe-finally eslint rule for devtools; r=jryans
authorTom Tromey <tom@tromey.com>
Thu, 05 Jan 2017 10:32:47 -0700
changeset 375580 7736a9b5fc05dc50989f77563f0189cdb74f2af6
parent 375579 c7f5fa45d3ae19b0d595c17a38ef400a0b1db12f
child 375581 d0f0fbb66c71697c972e6b90132049d29a578468
push id1419
push userjlund@mozilla.com
push dateMon, 10 Apr 2017 20:44:07 +0000
treeherdermozilla-release@5e6801b73ef6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjryans
bugs1328929
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1328929 - enable no-unsafe-finally eslint rule for devtools; r=jryans MozReview-Commit-ID: J8v5YELIyid
devtools/.eslintrc.js
--- a/devtools/.eslintrc.js
+++ b/devtools/.eslintrc.js
@@ -323,16 +323,18 @@ module.exports = {
     // Disallow the use of Boolean literals in conditional expressions.
     "no-unneeded-ternary": "error",
     // Disallow unreachable statements after a return, throw, continue, or break
     // statement.
     "no-unreachable": "error",
     // Disallow global and local variables that aren't used, but allow unused
     // function arguments.
     "no-unused-vars": ["error", {"vars": "all", "args": "none"}],
+    // Disallow flow control that escapes from "finally".
+    "no-unsafe-finally": "error",
     // Allow using variables before they are defined.
     "no-use-before-define": "off",
     // We use var-only-at-top-level instead of no-var as we allow top level
     // vars.
     "no-var": "off",
     // Allow using TODO/FIXME comments.
     "no-warning-comments": "off",
     // Disallow use of the with statement.