Bug 1511718 - Remove eSafeAgentSheetFeatures. r=emilio
authorCameron McCormack <cam@mcc.id.au>
Wed, 05 Dec 2018 21:18:21 +0000
changeset 508770 770eedbd66ab5b3980aeae5f4adc72d73a444939
parent 508769 43833d2f4dbd49a42fc8ffb0847f768320a9402e
child 508771 ec828a3edf1b280ff79d6e4ea58afc37896935b9
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersemilio
bugs1511718
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1511718 - Remove eSafeAgentSheetFeatures. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D13866
layout/style/SheetParsingMode.h
servo/ports/geckolib/glue.rs
--- a/layout/style/SheetParsingMode.h
+++ b/layout/style/SheetParsingMode.h
@@ -31,25 +31,19 @@ namespace css {
  * in user sheet are also available in author sheet.
  *
  * Agent sheets have access to all author- and user-sheet features
  * plus more extensions that are necessary for internal use but,
  * again, not yet suitable for exposure on the public Web.  Some of
  * these are outright unsafe to expose; in particular, incorrect
  * styling of anonymous box pseudo-elements can violate layout
  * invariants.
- *
- * Agent sheets that do not use any unsafe rules could use
- * eSafeAgentSheetFeatures when creating the sheet. This enum value allows
- * Servo backend to recognize the sheets as the agent level, but Gecko
- * backend will parse it under _author_ level.
  */
 enum SheetParsingMode : uint8_t {
   eAuthorSheetFeatures = 0,
   eUserSheetFeatures,
   eAgentSheetFeatures,
-  eSafeAgentSheetFeatures,
 };
 
 }  // namespace css
 }  // namespace mozilla
 
 #endif  // mozilla_css_SheetParsingMode_h
--- a/servo/ports/geckolib/glue.rs
+++ b/servo/ports/geckolib/glue.rs
@@ -1323,17 +1323,16 @@ pub extern "C" fn Servo_Element_IsPrimar
         .contains(data::ElementDataFlags::PRIMARY_STYLE_REUSED_VIA_RULE_NODE)
 }
 
 fn mode_to_origin(mode: SheetParsingMode) -> Origin {
     match mode {
         SheetParsingMode::eAuthorSheetFeatures => Origin::Author,
         SheetParsingMode::eUserSheetFeatures => Origin::User,
         SheetParsingMode::eAgentSheetFeatures => Origin::UserAgent,
-        SheetParsingMode::eSafeAgentSheetFeatures => Origin::UserAgent,
     }
 }
 
 #[no_mangle]
 pub extern "C" fn Servo_StyleSheet_Empty(
     mode: SheetParsingMode,
 ) -> RawServoStyleSheetContentsStrong {
     let global_style_data = &*GLOBAL_STYLE_DATA;