Bug 1018402: Disable VP8VideoTrackEncoder.FrameEncode on Windows because the test crashes on Windows, r=cku
authorBrian Smith <brian@briansmith.org>
Thu, 24 Apr 2014 20:11:27 -0700
changeset 207615 7673b3a0749997dddcbe768371fc99a3f174491b
parent 207614 44d8c7a29df144f61b5f7145ec47b07dfe34fed1
child 207616 fa797212429e813a44f198c59763a44027a1cadc
push id494
push userraliiev@mozilla.com
push dateMon, 25 Aug 2014 18:42:16 +0000
treeherdermozilla-release@a3cc3e46b571 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscku
bugs1018402
milestone32.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1018402: Disable VP8VideoTrackEncoder.FrameEncode on Windows because the test crashes on Windows, r=cku
content/media/gtest/TestVideoTrackEncoder.cpp
--- a/content/media/gtest/TestVideoTrackEncoder.cpp
+++ b/content/media/gtest/TestVideoTrackEncoder.cpp
@@ -241,16 +241,19 @@ TEST(VP8VideoTrackEncoder, FetchMetaData
 
     // METADATA should be depend on how to initiate encoder.
     EXPECT_TRUE(vp8Meta->mWidth == params[i].mWidth);
     EXPECT_TRUE(vp8Meta->mHeight == params[i].mHeight);
   }
 }
 
 // Encode test
+// XXX(bug 1018402): Disable this test when compiled with VS2013 because it
+// crashes.
+#if !defined(_MSC_VER) || _MSC_VER < 1800
 TEST(VP8VideoTrackEncoder, FrameEncode)
 {
   // Initiate VP8 encoder
   TestVP8TrackEncoder encoder;
   InitParam param = {true, 640, 480, 90000};
   encoder.TestInit(param);
 
   // Create YUV images as source.
@@ -270,16 +273,17 @@ TEST(VP8VideoTrackEncoder, FrameEncode)
 
   // track change notification.
   encoder.NotifyQueuedTrackChanges(nullptr, 0, 0, 0, 0, segment);
 
   // Pull Encoded Data back from encoder.
   EncodedFrameContainer container;
   EXPECT_TRUE(NS_SUCCEEDED(encoder.GetEncodedTrack(container)));
 }
+#endif // _MSC_VER
 
 // EOS test
 TEST(VP8VideoTrackEncoder, EncodeComplete)
 {
   // Initiate VP8 encoder
   TestVP8TrackEncoder encoder;
   InitParam param = {true, 640, 480, 90000};
   encoder.TestInit(param);