Bug 1457899 - use IPC_FAIL_NO_REASON instead of KillHard in ContentParent::RecvFileCreationRequest; r=baku
authorAlex Gaynor <agaynor@mozilla.com>
Fri, 27 Apr 2018 14:58:59 -0400
changeset 472436 76583b160138ca2ea6fcb71876c3ef2c7e4d48e0
parent 472435 25c5ae00eb5388349d20231d360c6b7710576afd
child 472437 ad861c124e5d793c3cb776ec3e50088a4786d547
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbaku
bugs1457899
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1457899 - use IPC_FAIL_NO_REASON instead of KillHard in ContentParent::RecvFileCreationRequest; r=baku MozReview-Commit-ID: LoO4Kxh7aZn
dom/ipc/ContentParent.cpp
--- a/dom/ipc/ContentParent.cpp
+++ b/dom/ipc/ContentParent.cpp
@@ -5580,17 +5580,16 @@ ContentParent::RecvFileCreationRequest(c
                                        const int64_t& aLastModified,
                                        const bool& aExistenceCheck,
                                        const bool& aIsFromNsIFile)
 {
   // We allow the creation of File via this IPC call only for the 'file' process
   // or for testing.
   if (!mRemoteType.EqualsLiteral(FILE_REMOTE_TYPE) &&
       !Preferences::GetBool("dom.file.createInChild", false)) {
-    KillHard("FileCreationRequest is not supported.");
     return IPC_FAIL_NO_REASON(this);
   }
 
   RefPtr<BlobImpl> blobImpl;
   nsresult rv =
     FileCreatorHelper::CreateBlobImplForIPC(aFullPath, aType, aName,
                                             aLastModifiedPassed,
                                             aLastModified, aExistenceCheck,