Bug 1440753 - Addendum: Initialize local bool to satisfy valgrind which somehow got upset. r=mattwoodrow
☠☠ backed out by 14ef02ecc303 ☠ ☠
authorBas Schouten <bschouten@mozilla.com>
Fri, 09 Mar 2018 07:05:21 +0100
changeset 462340 75ccc12de3267a8876946fc96f22189b7ef5ba32
parent 462339 9ed1661d198ea5eaad861d171c75a79004e3ca36
child 462341 91b5d3f7409fff1c6b091dc0e8906fa6a76ae7fc
push id1683
push usersfraser@mozilla.com
push dateThu, 26 Apr 2018 16:43:40 +0000
treeherdermozilla-release@5af6cb21869d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow
bugs1440753
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1440753 - Addendum: Initialize local bool to satisfy valgrind which somehow got upset. r=mattwoodrow MozReview-Commit-ID: AWmaObPEZHH
layout/generic/nsFrame.cpp
--- a/layout/generic/nsFrame.cpp
+++ b/layout/generic/nsFrame.cpp
@@ -5635,17 +5635,17 @@ nsFrame::ComputeSize(gfxContext*        
     }
   }
   bool isFlexItem = parentFrame && parentFrame->IsFlexContainerFrame() &&
     !parentFrame->HasAnyStateBits(NS_STATE_FLEX_IS_EMULATING_LEGACY_BOX) &&
     !HasAnyStateBits(NS_FRAME_OUT_OF_FLOW);
   // This bool only gets set (and used) if isFlexItem is true.
   // It indicates (for flex items) whether we're using their flex-basis for the
   // item's own ISize property vs. for its BSize property.
-  bool usingFlexBasisForISize;
+  bool usingFlexBasisForISize = false;
   if (isFlexItem) {
     // Flex items use their "flex-basis" property in place of their main-size
     // property (e.g. "width") for sizing purposes, *unless* they have
     // "flex-basis:auto", in which case they use their main-size property after
     // all.
     uint32_t flexDirection = GetParent()->StylePosition()->mFlexDirection;
     const bool flexContainerIsRowOriented =
       flexDirection == NS_STYLE_FLEX_DIRECTION_ROW ||