Bug 1502951 - Fix about:performance layout issues caused by scrollbars on small windows and on Windows. r=felipe, a=jcristau
authorFlorian Quèze <florian@queze.net>
Sat, 10 Nov 2018 17:09:23 +0100
changeset 501187 7596f6afa47537bacba4e0f490c522260afc5edf
parent 501186 afb34abc2e8b56e3d0955d9a9a20438f61ed5ec1
child 501188 315e01841499e0aa66783d3e463ec2450464f2cd
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfelipe, jcristau
bugs1502951
milestone64.0
Bug 1502951 - Fix about:performance layout issues caused by scrollbars on small windows and on Windows. r=felipe, a=jcristau
toolkit/components/aboutperformance/content/aboutPerformance.xhtml
--- a/toolkit/components/aboutperformance/content/aboutPerformance.xhtml
+++ b/toolkit/components/aboutperformance/content/aboutPerformance.xhtml
@@ -54,16 +54,17 @@
         -moz-user-select: none;
       }
       button.show_all_items {
         margin-top: .5cm;
         margin-left: 1cm;
       }
       body {
         margin-left: 1cm;
+        overflow-x: hidden;
       }
       div.measuring {
          background: url(chrome://global/skin/media/throbber.png) no-repeat center;
          min-width: 36px;
          min-height: 36px;
       }
       li.delta {
         border-left-width: 5px;
@@ -113,27 +114,31 @@
         font-size: 1em;
         border-spacing: 0;
         background-color: var(--in-content-box-background);
         margin: 0;
         position: absolute;
         top: 0;
         left: 0;
         width: 100%;
+        height: 100%;
+        min-width: 40em;
       }
 
       /* Avoid scrolling the header */
       #dispatch-tbody {
         display: block;
-        overflow-y: auto;
-        /* 2em is the height of the header, 1px is its border */
-        height: calc(100vh - 2em - 1px);
+        margin-top: 2em;
       }
       #dispatch-thead {
+        position: fixed;
+        z-index: 1;
         height: 2em;
+        border-bottom: 1px solid var(--in-content-border-color);
+        min-width: 40em;
       }
       #dispatch-thead, #dispatch-tbody tr {
         display: table;
         table-layout: fixed;
         width: 100%;
       }
       #dispatch-table td:nth-child(2) {
         width: 8em;
@@ -198,19 +203,16 @@
       .addon-icon:dir(rtl)::after {
         transform: scaleX(-1);
       }
       .close-icon::after {
         background-image: url("chrome://global/skin/icons/close.svg");
         background-size: 24px;
       }
 
-      #dispatch-table > tbody {
-        border-top: 1px solid var(--in-content-border-color);
-      }
       #dispatch-table > thead > tr > td {
         border: none;
         background-color: var(--in-content-box-background-hover);
         padding: 5px 10px;
       }
       #dispatch-table > thead > tr > td:not(:first-child) {
         border-inline-start-width: 1px;
         border-inline-start-style: solid;