Bug 1428852 - Crash reporter leaks file handle r=gsvelto
authorJean-Luc Bonnafoux <jeanluc.bonnafoux@wanadoo.fr>
Sun, 14 Jan 2018 17:39:40 +0100
changeset 453705 75678e33c933892981fc7a0ee86b25fcff2e59be
parent 453704 2d6ef6b74bfa2f2e1de2aeddc96a25bab6fd6000
child 453706 1da66dc8273245a0d0c80ae98afc8e8de196f346
push id1648
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 12:45:47 +0000
treeherdermozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgsvelto
bugs1428852
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1428852 - Crash reporter leaks file handle r=gsvelto MozReview-Commit-ID: IXeI73FipZv
toolkit/crashreporter/client/crashreporter_win.cpp
--- a/toolkit/crashreporter/client/crashreporter_win.cpp
+++ b/toolkit/crashreporter/client/crashreporter_win.cpp
@@ -1561,16 +1561,17 @@ void UIPruneSavedDumps(const std::string
     DeleteFile(path.c_str());
 
     // s/.dmp/.extra/
     path.replace(path.size() - 4, 4, L".extra");
     DeleteFile(path.c_str());
 
     dumpfiles.pop_back();
   }
+  FindClose(dirlist);
 }
 
 bool UIRunProgram(const string& exename,
                   const std::vector<std::string>& args,
                   bool wait)
 {
   wstring cmdLine = L"\"" + UTF8ToWide(exename) + L"\" ";