Bug 1441129 - "Change the Memory Tool's Snapshot List Item delete button from a div to a button" [r=mratcliffe]
authorMayank Madan <maddiemadan>
Thu, 01 Mar 2018 02:09:00 +0200
changeset 461062 7516a83ba950f147de219154f00cd4de39a5b01a
parent 461053 a416b0a21b1395dfe7dc28577a31be57c075d9b4
child 461063 61b461277369e0cec89c79d8526a82c575818e94
push id1683
push usersfraser@mozilla.com
push dateThu, 26 Apr 2018 16:43:40 +0000
treeherdermozilla-release@5af6cb21869d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmratcliffe
bugs1441129
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1441129 - "Change the Memory Tool's Snapshot List Item delete button from a div to a button" [r=mratcliffe]
devtools/client/memory/components/SnapshotListItem.js
devtools/client/themes/memory.css
--- a/devtools/client/memory/components/SnapshotListItem.js
+++ b/devtools/client/memory/components/SnapshotListItem.js
@@ -86,17 +86,17 @@ class SnapshotListItem extends Component
       details = dom.span({ className: "snapshot-state" }, statusText);
     }
 
     let saveLink = !snapshot.path ? void 0 : dom.a({
       onClick: () => onSave(snapshot),
       className: "save",
     }, L10N.getStr("snapshot.io.save"));
 
-    let deleteButton = !snapshot.path ? void 0 : dom.div({
+    let deleteButton = !snapshot.path ? void 0 : dom.button({
       onClick: () => onDelete(snapshot),
       className: "delete",
       title: L10N.getStr("snapshot.io.delete")
     });
 
     return (
       dom.li({ className, onClick },
         dom.span({
--- a/devtools/client/themes/memory.css
+++ b/devtools/client/themes/memory.css
@@ -204,19 +204,23 @@ html, body, #app, #memory-tool {
 
 .snapshot-list-item .save {
   text-decoration: underline;
   cursor: pointer;
 }
 
 .snapshot-list-item .delete {
   cursor: pointer;
+  background-color: transparent;
+  border: 0;
+  padding: 0;
   position: relative;
   min-height: 1em;
   min-width: 1.3em;
+  color: currentColor;
 }
 
 .snapshot-list-item .delete::before {
   display: block;
   width: 16px;
   height: 16px;
   content: "";
   background-image: url("chrome://devtools/skin/images/close.svg");