Bug 1576957 - [ci] Create 'attr' shortcut in target_tasks_ash, r=gbrown
authorAndrew Halberstadt <ahalberstadt@mozilla.com>
Wed, 28 Aug 2019 21:34:43 +0000
changeset 554707 734d2434e08bc19e3b904085e670b507daaf1759
parent 554706 ac42ae777d5cdab6ddbe4b01411be39910c2a069
child 554708 de27cb9fb807d14598298c986b302f1e94c1facf
push id2165
push userffxbld-merge
push dateMon, 14 Oct 2019 16:30:58 +0000
treeherdermozilla-release@0eae18af659f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgbrown
bugs1576957
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1576957 - [ci] Create 'attr' shortcut in target_tasks_ash, r=gbrown Differential Revision: https://phabricator.services.mozilla.com/D43806
taskcluster/taskgraph/target_tasks.py
--- a/taskcluster/taskgraph/target_tasks.py
+++ b/taskcluster/taskgraph/target_tasks.py
@@ -179,40 +179,41 @@ def target_tasks_default(full_task_graph
             if standard_filter(t, parameters)
             and filter_out_nightly(t, parameters)]
 
 
 @_target_task('ash_tasks')
 def target_tasks_ash(full_task_graph, parameters, graph_config):
     """Target tasks that only run on the ash branch."""
     def filter(task):
-        platform = task.attributes.get('build_platform')
+        attr = task.attributes
+        platform = attr.get('build_platform')
         # Early return if platform is None
         if not platform:
             return False
         # Only on Linux platforms
         if 'linux' not in platform:
             return False
         # No random non-build jobs either. This is being purposely done as a
         # blacklist so newly-added jobs aren't missed by default.
         for p in ('nightly', 'haz', 'artifact', 'cov', 'add-on'):
             if p in platform:
                 return False
         for k in ('toolchain', 'l10n'):
-            if k in task.attributes['kind']:
+            if k in attr['kind']:
                 return False
         # and none of this linux64-asan/debug stuff
-        if platform == 'linux64-asan' and task.attributes['build_type'] == 'debug':
+        if platform == 'linux64-asan' and attr['build_type'] == 'debug':
             return False
         # no non-e10s tests
-        if task.attributes.get('unittest_suite'):
-            if not task.attributes.get('e10s'):
+        if attr.get('unittest_suite'):
+            if not attr.get('e10s'):
                 return False
         # don't upload symbols
-        if task.attributes['kind'] == 'upload-symbols':
+        if attr['kind'] == 'upload-symbols':
             return False
         return True
 
     return [l for l, t in full_task_graph.tasks.iteritems()
             if filter(t)
             and standard_filter(t, parameters)
             and filter_out_nightly(t, parameters)]