Bug 1577324 - Always style the error code field in error pages as a link. r=nhnt11
authorJohann Hofmann <jhofmann@mozilla.com>
Fri, 30 Aug 2019 10:14:45 +0000
changeset 554602 71f0bf2aee9b7643446a83a7aef67d704eb373a9
parent 554601 1973d4f4c3a2eb392c366cbb89443aa9ba904350
child 554603 dd6e8cc3c3d4d155c69de00c8357d45a8e5d94b7
push id2165
push userffxbld-merge
push dateMon, 14 Oct 2019 16:30:58 +0000
treeherdermozilla-release@0eae18af659f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnhnt11
bugs1577324
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1577324 - Always style the error code field in error pages as a link. r=nhnt11 The way that we're setting this now actually makes it impossible for this not to be a link, AFAICS. Differential Revision: https://phabricator.services.mozilla.com/D44055
browser/themes/shared/aboutNetError.css
--- a/browser/themes/shared/aboutNetError.css
+++ b/browser/themes/shared/aboutNetError.css
@@ -141,23 +141,18 @@ body:not(.neterror) #advancedButton {
 
 #automaticallyReportInFuture {
   cursor: pointer;
   /* Prevent the checkbox from looking super
    * squeezed on small viewports */
   flex-shrink: 0;
 }
 
-#errorCode:not([href]) {
-  color: var(--in-content-page-color);
-  cursor: text;
-  text-decoration: none;
-}
-
-#errorCode[href] {
+#errorCode {
+  cursor: pointer;
   white-space: nowrap;
 }
 
 #viewCertificate {
   margin: 0 3em;
 }
 
 #badCertTechnicalInfo {
@@ -264,14 +259,14 @@ body:not(.neterror) #advancedButton {
   #badCertTechnicalInfo {
     margin: 10px 10px 5px;
   }
 
   #viewCertificate {
     margin: 0 10px;
   }
 
-  #errorCode[href] {
+  #errorCode {
     /* Break the error code to avoid long codes overflowing the screen */
     white-space: normal;
     word-wrap: anywhere;
   }
 }