Backed out 2 changesets (bug 1424967) for f8 lint failures in /builds/worker/checkouts/gecko/toolkit/crashreporter/tools/upload_symbols.py:78:5 on a CLOSED TREE
authorNoemi Erli <nerli@mozilla.com>
Wed, 17 Jan 2018 02:07:20 +0200
changeset 453851 714891013247ad615b4b2f5b2075bf7167ee6ff0
parent 453850 fb5c087381a6f8027b9bb804ea9cc2927b809626
child 453852 bf2a3f50b5f9e099a0db58bf35764a974c41a3aa
push id1648
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 12:45:47 +0000
treeherdermozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1424967
milestone59.0a1
backs out02a7d3b84dcd08e6c6a0646c49870306f3d6579a
e027f4bf3ed2324f094eed7e6fe51a53f05dd355
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 2 changesets (bug 1424967) for f8 lint failures in /builds/worker/checkouts/gecko/toolkit/crashreporter/tools/upload_symbols.py:78:5 on a CLOSED TREE Backed out changeset 02a7d3b84dcd (bug 1424967) Backed out changeset e027f4bf3ed2 (bug 1424967)
toolkit/crashreporter/tools/upload_symbols.py
tools/lint/flake8.yml
--- a/toolkit/crashreporter/tools/upload_symbols.py
+++ b/toolkit/crashreporter/tools/upload_symbols.py
@@ -22,24 +22,25 @@ import os
 import sys
 from mozbuild.base import MozbuildObject
 log = logging.getLogger('upload-symbols')
 log.setLevel(logging.INFO)
 
 DEFAULT_URL = 'https://symbols.mozilla.org/upload/'
 MAX_RETRIES = 5
 
-
 def print_error(r):
     if r.status_code < 400:
         log.error('Error: bad auth token? ({0}: {1})'.format(r.status_code,
-                                                             r.reason))
+                                                         r.reason),
+                  file=sys.stderr)
     else:
         log.error('Error: got HTTP response {0}: {1}'.format(r.status_code,
-                                                             r.reason))
+                                                         r.reason),
+                  file=sys.stderr)
 
     log.error('Response body:\n{sep}\n{body}\n{sep}\n'.format(
         sep='=' * 20,
         body=r.text
         ))
 
 
 def get_taskcluster_secret(secret_name):
@@ -66,33 +67,33 @@ def main():
     logging.basicConfig()
     parser = argparse.ArgumentParser(
         description='Upload symbols in ZIP using token from Taskcluster secrets service.')
     parser.add_argument('zip',
                         help='Symbols zip file - URL or path to local file')
     args = parser.parse_args()
 
     if not args.zip.startswith('http') and not os.path.isfile(args.zip):
-        log.error('Error: zip file "{0}" does not exist!'.format(args.zip))
+        log.error('Error: zip file "{0}" does not exist!'.format(args.zip),
+                  file=sys.stderr)
         return 1
 
 
     secret_name = os.environ.get('SYMBOL_SECRET')
     if secret_name is not None:
         auth_token = get_taskcluster_secret(secret_name)
     elif 'SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE' in os.environ:
         token_file = os.environ['SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE']
 
         if not os.path.isfile(token_file):
-            log.error('SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE "{0}" does not exist!'.format(token_file))
+            log.error('SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE "{0}" does not exist!'.format(token_file), file=sys.stderr)
             return 1
         auth_token = open(token_file, 'r').read().strip()
     else:
-        log.error('You must set the SYMBOL_SECRET or SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE '
-                  'environment variables!')
+        log.error('You must set the SYMBOL_SECRET or SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE environment variables!')
         return 1
 
     # Allow overwriting of the upload url with an environmental variable
     if 'SOCORRO_SYMBOL_UPLOAD_URL' in os.environ:
         url = os.environ['SOCORRO_SYMBOL_UPLOAD_URL']
     elif os.environ.get('MOZ_SCM_LEVEL', '1') == '1':
         # Use the Tecken staging server for try uploads for now.
         # This will eventually be changed in bug 1138617.
@@ -132,11 +133,10 @@ def main():
 
     if r.status_code >= 200 and r.status_code < 300:
         log.info('Uploaded successfully!')
         return 0
 
     print_error(r)
     return 1
 
-
 if __name__ == '__main__':
     sys.exit(main())
--- a/tools/lint/flake8.yml
+++ b/tools/lint/flake8.yml
@@ -1,17 +1,17 @@
 ---
 flake8:
     description: Python linter
     include:
+        - build/moz.configure/*.configure
         - build/*.py
-        - build/moz.configure/*.configure
+        - configure.py
         - config/check_macroassembler_style.py
         - config/mozunit.py
-        - configure.py
         - layout/tools/reftest
         - python/mach
         - python/mach_commands.py
         - python/mozboot
         - python/mozbuild/mozpack/path.py
         - python/mozlint
         - python/mozterm
         - python/mozversioncontrol
@@ -27,22 +27,21 @@ flake8:
         - testing/mozharness/mozfile
         - testing/mozharness/mozharness/mozilla/mar.py
         - testing/mozharness/mozinfo
         - testing/mozharness/scripts
         - testing/remotecppunittests.py
         - testing/runcppunittests.py
         - testing/talos/
         - testing/xpcshell
-        - toolkit/components/telemetry
-        - toolkit/crashreporter/tools/upload_symbols.py
         - tools/git
         - tools/lint
         - tools/mach_commands.py
         - tools/mercurial
         - tools/tryselect
+        - toolkit/components/telemetry
     # Excludes should be added to topsrcdir/.flake8 due to a bug in flake8 where
     # specifying --exclude causes custom configuration files to be ignored.
     exclude: []
     # The configure option is used by the build system
     extensions: ['configure', 'py']
     type: external
     payload: python.flake8:lint