Bug 1547830 - Ensure updated WNP is shown in the Trailhead dot release (aka 67.0.5) r=Gijs a=jcristau
authorEd Lee <edilee@mozilla.com>
Wed, 22 May 2019 18:57:34 -0700
changeset 536580 6fc87a979fcb6667944d1fb1cdcc9cd8f70acce5
parent 536579 5fb77819e231aad9231f89c33b5a573bb1779f21
child 536581 b488a5cc9dfb0751a096461165c5b243a48ee0ad
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs, jcristau
bugs1547830
milestone68.0
Bug 1547830 - Ensure updated WNP is shown in the Trailhead dot release (aka 67.0.5) r=Gijs a=jcristau Reviewers: Gijs Reviewed By: Gijs Subscribers: tomprince Bug #: 1547830 Differential Revision: https://phabricator.services.mozilla.com/D31745
browser/components/BrowserContentHandler.jsm
--- a/browser/components/BrowserContentHandler.jsm
+++ b/browser/components/BrowserContentHandler.jsm
@@ -548,38 +548,33 @@ nsBrowserContentHandler.prototype = {
           case OVERRIDE_NEW_PROFILE:
             // New profile.
             overridePage = Services.urlFormatter.formatURLPref("startup.homepage_welcome_url");
             additionalPage = Services.urlFormatter.formatURLPref("startup.homepage_welcome_url.additional");
             // Turn on 'later run' pages for new profiles.
             LaterRun.enabled = true;
             break;
           case OVERRIDE_NEW_MSTONE:
+          case OVERRIDE_NEW_BUILD_ID:
             // Check whether we will restore a session. If we will, we assume
             // that this is an "update" session. This does not take crashes
             // into account because that requires waiting for the session file
             // to be read. If a crash occurs after updating, before restarting,
             // we may open the startPage in addition to restoring the session.
             willRestoreSession = SessionStartup.isAutomaticRestoreEnabled();
 
             overridePage = Services.urlFormatter.formatURLPref("startup.homepage_override_url");
             if (prefb.prefHasUserValue("app.update.postupdate")) {
               overridePage = getPostUpdateOverridePage(overridePage);
               // Send the update ping to signal that the update was successful.
               UpdatePing.handleUpdateSuccess(old_mstone, old_buildId);
             }
 
             overridePage = overridePage.replace("%OLD_VERSION%", old_mstone);
             break;
-          case OVERRIDE_NEW_BUILD_ID:
-            if (prefb.prefHasUserValue("app.update.postupdate")) {
-              // Send the update ping to signal that the update was successful.
-              UpdatePing.handleUpdateSuccess(old_mstone, old_buildId);
-            }
-            break;
         }
       }
     } catch (ex) {}
 
     // formatURLPref might return "about:blank" if getting the pref fails
     if (overridePage == "about:blank")
       overridePage = "";