Bug 942958 - Fix bug where a failure to populate the foundation of a peerreflexive candidate would result in an incorrect error return from nr_ice_peer_peer_rflx_candidate_create. r=ekr
authorByron Campen [:bwc] <docfaraday@gmail.com>
Mon, 25 Nov 2013 13:13:05 -0800
changeset 174333 6ede459abb057c6f4454736df432b04a1d3508d2
parent 174332 ff49c9feb4664b938a76a1c7b9d78038c1d4100b
child 174334 fdd48523bfbe0dac009be30e989a6aec6271259f
push id445
push userffxbld
push dateMon, 10 Mar 2014 22:05:19 +0000
treeherdermozilla-release@dc38b741b04e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersekr
bugs942958
milestone28.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 942958 - Fix bug where a failure to populate the foundation of a peerreflexive candidate would result in an incorrect error return from nr_ice_peer_peer_rflx_candidate_create. r=ekr
media/mtransport/third_party/nICEr/src/ice/ice_candidate.c
--- a/media/mtransport/third_party/nICEr/src/ice/ice_candidate.c
+++ b/media/mtransport/third_party/nICEr/src/ice/ice_candidate.c
@@ -231,17 +231,17 @@ int nr_ice_peer_peer_rflx_candidate_crea
       ctx->label,label,nr_ctype_name(ctype));
 
     if(r=nr_transport_addr_copy(&cand->base,addr))
       ABORT(r);
     if(r=nr_transport_addr_copy(&cand->addr,addr))
       ABORT(r);
     /* Bogus foundation */
     if(!(cand->foundation=r_strdup(cand->addr.as_string)))
-      ABORT(r);
+      ABORT(R_NO_MEMORY);
 
     nr_ice_candidate_compute_codeword(cand);
 
     *candp=cand;
 
     _status=0;
   abort:
     if (_status){