Bug 1576034 - Fix bare-trait-objects warnings in direct-composition. r=jrmuizel
authorMike Hommey <mh+mozilla@glandium.org>
Mon, 26 Aug 2019 12:00:56 +0000
changeset 553708 6ebe9191d22fce49cde5ae0bbb0d795ec2fad6f9
parent 553707 adfc9e87dbcd35560a614920e27ca559b5f6f256
child 553709 4f44ce28f9ead90d9eefb03523e212f43763791c
push id2165
push userffxbld-merge
push dateMon, 14 Oct 2019 16:30:58 +0000
treeherdermozilla-release@0eae18af659f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjrmuizel
bugs1576034
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1576034 - Fix bare-trait-objects warnings in direct-composition. r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D43204
gfx/wr/direct-composition/src/lib.rs
gfx/wr/direct-composition/src/main_windows.rs
--- a/gfx/wr/direct-composition/src/lib.rs
+++ b/gfx/wr/direct-composition/src/lib.rs
@@ -23,17 +23,17 @@ use winapi::um::dcomp::IDCompositionVisu
 mod com;
 mod egl;
 
 pub struct DirectComposition {
     d3d_device: ComPtr<ID3D11Device>,
     dxgi_factory: ComPtr<IDXGIFactory2>,
 
     egl: Rc<egl::SharedEglThings>,
-    pub gleam: Rc<gleam::gl::Gl>,
+    pub gleam: Rc<dyn gleam::gl::Gl>,
 
     composition_device: ComPtr<IDCompositionDevice>,
     root_visual: ComPtr<IDCompositionVisual>,
 
     #[allow(unused)]  // Needs to be kept alive
     composition_target: ComPtr<IDCompositionTarget>,
 }
 
@@ -145,17 +145,17 @@ impl DirectComposition {
     }
 }
 
 /// A DirectComposition "visual" configured for rendering with Direct3D.
 pub struct AngleVisual {
     visual: ComPtr<IDCompositionVisual>,
     swap_chain: ComPtr<winapi::shared::dxgi1_2::IDXGISwapChain1>,
     egl: egl::PerVisualEglThings,
-    pub gleam: Rc<gleam::gl::Gl>,
+    pub gleam: Rc<dyn gleam::gl::Gl>,
 }
 
 impl AngleVisual {
     pub fn set_offset_x(&self, offset_x: f32) {
         unsafe {
             self.visual.SetOffsetX_1(offset_x).check_hresult()
         }
     }
--- a/gfx/wr/direct-composition/src/main_windows.rs
+++ b/gfx/wr/direct-composition/src/main_windows.rs
@@ -189,17 +189,17 @@ impl Drop for Rectangle {
 
 #[derive(Clone)]
 struct Notifier {
     events_proxy: winit::EventsLoopProxy,
     tx: mpsc::Sender<()>,
 }
 
 impl api::RenderNotifier for Notifier {
-    fn clone(&self) -> Box<api::RenderNotifier> {
+    fn clone(&self) -> Box<dyn api::RenderNotifier> {
         Box::new(Clone::clone(self))
     }
 
     fn wake_up(&self) {
         self.tx.send(()).unwrap();
         let _ = self.events_proxy.wakeup();
     }