Backed out changeset dc318b0913b9 (bug 1373672)
authorSebastian Hengst <archaeopteryx@coole-files.de>
Tue, 01 Aug 2017 12:38:25 +0200
changeset 423316 6da77209f66bc33af8a22905bb75007ef59e0abb
parent 423315 896709cd1daf82ebe88f444e90ea3f2c995d49b9
child 423317 0c274a6f7b7b9b41b4b29e34037f4f60244f8d05
push id1517
push userjlorenzo@mozilla.com
push dateThu, 14 Sep 2017 16:50:54 +0000
treeherdermozilla-release@3b41fd564418 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1373672
milestone56.0a1
backs outdc318b0913b97dba5f8c8ec2735f96b7d5a30d69
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset dc318b0913b9 (bug 1373672)
docshell/base/nsDocShell.cpp
docshell/base/nsDocShell.h
docshell/base/nsIDocShell.idl
--- a/docshell/base/nsDocShell.cpp
+++ b/docshell/base/nsDocShell.cpp
@@ -4078,17 +4078,17 @@ nsDocShell::SetTreeOwner(nsIDocShellTree
   // performance-critical, let's be safe and unconditionally recompute this
   // state whenever dependent state changes.
   RecomputeCanExecuteScripts();
 
   return NS_OK;
 }
 
 NS_IMETHODIMP
-nsDocShell::SetChildOffset(int32_t aChildOffset)
+nsDocShell::SetChildOffset(uint32_t aChildOffset)
 {
   mChildOffset = aChildOffset;
   return NS_OK;
 }
 
 NS_IMETHODIMP
 nsDocShell::GetHistoryID(nsID** aID)
 {
--- a/docshell/base/nsDocShell.h
+++ b/docshell/base/nsDocShell.h
@@ -901,17 +901,17 @@ protected:
 
   nsIDocShellTreeOwner* mTreeOwner; // Weak Reference
   mozilla::dom::EventTarget* mChromeEventHandler; // Weak Reference
 
   eCharsetReloadState mCharsetReloadState;
 
   // Offset in the parent's child list.
   // -1 if the docshell is added dynamically to the parent shell.
-  int32_t mChildOffset;
+  uint32_t mChildOffset;
   uint32_t mBusyFlags;
   uint32_t mAppType;
   uint32_t mLoadType;
 
   int32_t mMarginWidth;
   int32_t mMarginHeight;
 
   // This can either be a content docshell or a chrome docshell. After
--- a/docshell/base/nsIDocShell.idl
+++ b/docshell/base/nsIDocShell.idl
@@ -546,17 +546,17 @@ interface nsIDocShell : nsIDocShellTreeI
    * For a new document load, this will be the channel of the previous document
    * until after OnLocationChange fires.
    */
   readonly attribute nsIChannel currentDocumentChannel;
 
   /**
    * Set the offset of this child in its container.
    */
-  [noscript] void setChildOffset(in long offset);
+  [noscript] void setChildOffset(in unsigned long offset);
 
   /**
    * Find out whether the docshell is currently in the middle of a page
    * transition. This is set just before the pagehide/unload events fire.
    */
   readonly attribute boolean isInUnload;
 
   /**