Bug 1370539 - Fix logic error around skipping package metrics; r=nalexander, a=RyanVM
authorGregory Szorc <gps@mozilla.com>
Tue, 06 Jun 2017 11:09:58 -0700
changeset 412948 6cd0639e02ded96057e7fa325623a1245efd4535
parent 412947 c511ad826fe71ba2bb956d2e1c119e86d2266aba
child 413013 fd04166b7114949ce63783e10a069b98d76df573
push id1490
push usermtabara@mozilla.com
push dateMon, 31 Jul 2017 14:08:16 +0000
treeherdermozilla-release@70e32e6bf15e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander, RyanVM
bugs1370539
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1370539 - Fix logic error around skipping package metrics; r=nalexander, a=RyanVM b227363d66bb added a config item and code for disabling package metrics, which don't work everywhere. The previous logic was faulty. MozReview-Commit-ID: BGxWgmWxXyH Pushing on a CLOSED TREE
testing/mozharness/mozharness/mozilla/building/buildbase.py
--- a/testing/mozharness/mozharness/mozilla/building/buildbase.py
+++ b/testing/mozharness/mozharness/mozilla/building/buildbase.py
@@ -2028,17 +2028,17 @@ or run without that action (ie: --no-{ac
 
         perfherder_data = {
             "framework": {
                 "name": "build_metrics"
             },
             "suites": [],
         }
 
-        if not c.get('debug_build') or c.get('disable_package_metrics'):
+        if not c.get('debug_build') and not c.get('disable_package_metrics'):
             perfherder_data['suites'].extend(self._get_package_metrics())
 
         # Extract compiler warnings count.
         warnings = self.get_output_from_command(
             command=[sys.executable, 'mach', 'warnings-list'],
             cwd=self.query_abs_dirs()['abs_src_dir'],
             env=self.query_build_env(),
             # No need to pollute the log.