Bug 998481 - Checked items in subview panels have checkmarks on the wrong side in RTL locales. r=jaws, feedback=mikedeboer.
authorMike Conley <mconley@mozilla.com>
Tue, 22 Apr 2014 08:22:00 -0400
changeset 199169 6bdd0bb387d628d92cdb16ac29eacbebdc1a9b6c
parent 199168 7ede33d15218451fedc85a038bf6a81851a115dd
child 199170 ff282758a46d5f42ecd0ad0183e19df41223a0bc
push id486
push userasasaki@mozilla.com
push dateMon, 14 Jul 2014 18:39:42 +0000
treeherdermozilla-release@d33428174ff1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs998481
milestone31.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 998481 - Checked items in subview panels have checkmarks on the wrong side in RTL locales. r=jaws, feedback=mikedeboer.
browser/themes/osx/customizableui/panelUIOverlay.css
browser/themes/shared/customizableui/panelUIOverlay.inc.css
--- a/browser/themes/osx/customizableui/panelUIOverlay.css
+++ b/browser/themes/osx/customizableui/panelUIOverlay.css
@@ -94,16 +94,20 @@
 .subviewbutton {
   -moz-padding-start: 18px;
 }
 
 .subviewbutton[checked="true"] {
   background-position: top 5px left 4px;
 }
 
+.subviewbutton[checked="true"]:-moz-locale-dir(rtl) {
+  background-position: top 5px right 4px;
+}
+
 .subviewbutton:not(:-moz-any([image],[targetURI],.cui-withicon, .bookmark-item)) > .menu-iconic-left {
   display: none;
 }
 
 menu.subviewbutton,
 menuitem.subviewbutton:not(.panel-subview-footer) {
   padding-top: 2px;
   padding-bottom: 2px;
--- a/browser/themes/shared/customizableui/panelUIOverlay.inc.css
+++ b/browser/themes/shared/customizableui/panelUIOverlay.inc.css
@@ -1063,16 +1063,20 @@ toolbaritem[overflowedItem=true],
   background-size: 1px 18px;
   box-shadow: 0 0 0 1px hsla(0,0%,100%,.2);
 }
 
 .subviewbutton[checked="true"] {
   background: url("chrome://global/skin/menu/shared-menu-check.png") center left 7px / 11px 11px no-repeat transparent;
 }
 
+.subviewbutton[checked="true"]:-moz-locale-dir(rtl) {
+  background-position: center right 7px;
+}
+
 .subviewbutton > .menu-iconic-left {
   -moz-appearance: none;
   -moz-margin-end: 3px;
 }
 
 menuitem[checked="true"].subviewbutton > .menu-iconic-left {
   visibility: hidden;
 }