Bug 1399930 - Add drag space padding to the tabs toolbar on OSX. r=Gijs
authorJohann Hofmann <jhofmann@mozilla.com>
Fri, 15 Sep 2017 12:55:18 +0200
changeset 433339 6bd0d9d8bc16a931642be34c54dd3522a4dce6d3
parent 433338 2189a968511ee8f51eb2deb046bd7914a76a693b
child 433340 7ae99bcbaac4c84a727d4c81de529f5714b5c2cd
push id1567
push userjlorenzo@mozilla.com
push dateThu, 02 Nov 2017 12:36:05 +0000
treeherdermozilla-release@e512c14a0406 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1399930
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1399930 - Add drag space padding to the tabs toolbar on OSX. r=Gijs The previous drag space was only set as min-height on the titlebar, which led tabsintitlebar.js to not account that extra space for moving the titlebar to the bottom (because it calculates that height from tab strip height). So while it looked fine visually, the titlebar did not stretch all the way to the bottom, so that e.g. double-clicks aren't registered correctly. MozReview-Commit-ID: 1mHFDBUe3sC
browser/themes/osx/browser.css
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -884,28 +884,28 @@ html|span.ac-emphasize-text-url {
 .tabbrowser-tab:focus > .tab-stack > .tab-content > .tab-throbber[pinned] {
   box-shadow: var(--focus-ring-box-shadow);
 }
 
 #TabsToolbar {
   -moz-appearance: none;
   /* overlap the nav-bar's top border */
   margin-bottom: calc(-1 * var(--tab-toolbar-navbar-overlap));
+  padding-top: var(--space-above-tabbar);
 }
 
 :root:not([customizing]):not([tabsintitlebar]):not([inFullscreen]) #TabsToolbar:not(:-moz-lwtheme) {
   -moz-appearance: toolbar;
 }
 
 #TabsToolbar:not(:-moz-lwtheme) {
   color: #333;
   text-shadow: @loweredShadow@;
 }
 
-#main-window[tabsintitlebar] > #titlebar:not(:-moz-lwtheme),
 :root:-moz-any([inFullscreen], [tabsintitlebar]) #TabsToolbar:not(:-moz-lwtheme) {
   -moz-appearance: -moz-mac-vibrancy-dark;
   -moz-font-smoothing-background-color: -moz-mac-vibrancy-dark;
   background-color: #232323;
   color: hsl(240, 9%, 98%);
   text-shadow: none;
 }