Bug 1186987 - If file_path is None do not check if it is an executable. DONTBUILD. r=jlund a=testing
authorArmen Zambrano Gasparnian <armenzg@mozilla.com>
Fri, 24 Jul 2015 11:03:03 -0400
changeset 275448 6bb14eb443255685083793fdf88617fd01a52aaa
parent 275447 bcd72a368f81780688f0d6cfbed40f5ecc1f0f7a
child 275451 a9b694bfbc421e59ee53ae7f65a184243c4655ae
push id863
push userraliiev@mozilla.com
push dateMon, 03 Aug 2015 13:22:43 +0000
treeherdermozilla-release@f6321b14228d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjlund, testing
bugs1186987
milestone40.0
Bug 1186987 - If file_path is None do not check if it is an executable. DONTBUILD. r=jlund a=testing
testing/mozharness/mozharness/mozilla/vcstools.py
--- a/testing/mozharness/mozharness/mozilla/vcstools.py
+++ b/testing/mozharness/mozharness/mozilla/vcstools.py
@@ -44,15 +44,14 @@ class VCSToolsScript(VCSScript):
             for vcs_tool in VCS_TOOLS:
                 file_path = self.which(vcs_tool)
 
                 # If the tool is specified and it is a list is
                 # because we're running on Windows and we won't check
                 if type(self.query_exe(vcs_tool)) is list:
                     continue
 
-                if not self.is_exe(file_path):
-                    self.critical("%s is not executable." % file_path)
-
                 if file_path is None:
                     self.fatal("This machine is missing %s, if this is your "
                                "local machine you can use --cfg "
                                "developer_config.py" % vcs_tool)
+                elif not self.is_exe(file_path):
+                    self.critical("%s is not executable." % file_path)