Bug 1247410 - "test for _nomap ids does not work correctly". r=dougt
authorVictor Ng <vng>
Thu, 11 Feb 2016 06:23:00 +0100
changeset 324885 6b33413601b004af5f66c5e74df137f2e1acfa6c
parent 324884 d0d03be48b9e6e6422e467e6ee519b9bada6ea99
child 324886 b670d8ff99cac57c38e8894f5d232ff389e9db89
push id1128
push userjlund@mozilla.com
push dateWed, 01 Jun 2016 01:31:59 +0000
treeherdermozilla-release@fe0d30de989d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdougt
bugs1247410
milestone47.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1247410 - "test for _nomap ids does not work correctly". r=dougt
dom/system/NetworkGeolocationProvider.js
--- a/dom/system/NetworkGeolocationProvider.js
+++ b/dom/system/NetworkGeolocationProvider.js
@@ -378,18 +378,19 @@ WifiGeoPositionProvider.prototype = {
     // we got some wifi data, rearm the timer.
     this.resetTimer();
 
     function isPublic(ap) {
       let mask = "_nomap"
       let result = ap.ssid.indexOf(mask, ap.ssid.length - mask.length);
       if (result != -1) {
         LOG("Filtering out " + ap.ssid + " " + result);
+        return false;
       }
-      return result;
+      return true;
     };
 
     function sort(a, b) {
       return b.signal - a.signal;
     };
 
     function encode(ap) {
       return { 'macAddress': ap.mac, 'signalStrength': ap.signal };