Bug 1210157 - Add Python 3 support to the mozboot Debian bootstrapper r=firefox-build-system-reviewers,mshal
authorMāris Fogels <mars@mozilla.com>
Tue, 20 Aug 2019 21:19:17 +0000
changeset 553823 6a5f5594422fa3120fdc6f2ff5a8cbf072f94b42
parent 553822 41bebeeebc277d0b23b6a55331ad97319be63d60
child 553824 d79183b963e7c47d26150f31f0179888f3b51fd2
push id2165
push userffxbld-merge
push dateMon, 14 Oct 2019 16:30:58 +0000
treeherdermozilla-release@0eae18af659f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfirefox-build-system-reviewers, mshal
bugs1210157
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1210157 - Add Python 3 support to the mozboot Debian bootstrapper r=firefox-build-system-reviewers,mshal Add support for Python 3 and Python 2.7 to the Debian-based linux distro bootstrap routines. Differential Revision: https://phabricator.services.mozilla.com/D39361
python/mozboot/mozboot/debian.py
--- a/python/mozboot/mozboot/debian.py
+++ b/python/mozboot/mozboot/debian.py
@@ -104,18 +104,18 @@ class DebianBootstrapper(NasmInstall, No
         # Python 3 may not be present on all distros. Search for it and
         # install if found.
         packages = list(self.packages)
 
         have_python3 = any([self.which('python3'), self.which('python3.6'),
                             self.which('python3.5')])
 
         if not have_python3:
-            python3_packages = self.check_output([
-                'apt-cache', 'pkgnames', 'python3'])
+            python3_packages = self.check_output(
+                ['apt-cache', 'pkgnames', 'python3'], universal_newlines=True)
             python3_packages = python3_packages.splitlines()
 
             if 'python3' in python3_packages:
                 packages.extend(['python3', 'python3-dev'])
 
         self.apt_install(*packages)
 
     def install_browser_packages(self):