Bug 1479071 - Revert kPMDataFormatXMLCompressed to kPMDataFormatXMLNormal. r=mstange
authorMantaroh Yoshinaga <mantaroh@gmail.com>
Wed, 22 Aug 2018 02:07:28 +0000
changeset 490491 69fdbbb5facc288292c4d1f0057ac911f7422956
parent 490490 93031405a2de5f24f9fc3479a9eee3189bf5c453
child 490492 c9d2c08bea3cdc95ce6bad70ac29bbd0a2fd13d7
push id1815
push userffxbld-merge
push dateMon, 15 Oct 2018 10:40:45 +0000
treeherdermozilla-release@18d4c09e9378 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange
bugs1479071, 1411879
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1479071 - Revert kPMDataFormatXMLCompressed to kPMDataFormatXMLNormal. r=mstange Bug 1411879 introduced kPMDataFormatXMLCompress. However, this parameter caused the saving print settings problem. Before investigating this reason, this patch will revert this parameter. Differential Revision: https://phabricator.services.mozilla.com/D3943
widget/cocoa/nsPrintSettingsX.mm
--- a/widget/cocoa/nsPrintSettingsX.mm
+++ b/widget/cocoa/nsPrintSettingsX.mm
@@ -156,17 +156,17 @@ NS_IMETHODIMP nsPrintSettingsX::WritePag
 {
   NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT;
 
   PMPageFormat pageFormat = GetPMPageFormat();
   if (pageFormat == kPMNoPageFormat)
     return NS_ERROR_NOT_INITIALIZED;
 
   NSData* data = nil;
-  OSStatus err = ::PMPageFormatCreateDataRepresentation(pageFormat, (CFDataRef*)&data, kPMDataFormatXMLCompressed);
+  OSStatus err = ::PMPageFormatCreateDataRepresentation(pageFormat, (CFDataRef*)&data, kPMDataFormatXMLDefault);
   if (err != noErr)
     return NS_ERROR_FAILURE;
 
   nsAutoCString encodedData;
   encodedData.Adopt(PL_Base64Encode((char*)[data bytes], [data length], nullptr));
   if (!encodedData.get())
     return NS_ERROR_OUT_OF_MEMORY;