Backed out changeset 0462e7a66185 (bug 1369801)
authorSebastian Hengst <archaeopteryx@coole-files.de>
Thu, 27 Jul 2017 18:14:08 +0200
changeset 422473 68ab4d2e7d854952b2df2ac38d43bf3c18687588
parent 422472 952d7e686b62e994ca019028b0eac1281fff4990
child 422474 b341a33c034274d8aa6ddcba74e178809ae23a4b
push id1517
push userjlorenzo@mozilla.com
push dateThu, 14 Sep 2017 16:50:54 +0000
treeherdermozilla-release@3b41fd564418 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1369801
milestone56.0a1
backs out0462e7a66185a233fe9cbd389c9ca45a7e860565
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 0462e7a66185 (bug 1369801) MozReview-Commit-ID: Hc6hLI0Ywxj
devtools/client/framework/ToolboxProcess.jsm
--- a/devtools/client/framework/ToolboxProcess.jsm
+++ b/devtools/client/framework/ToolboxProcess.jsm
@@ -182,39 +182,25 @@ BrowserToolboxProcess.prototype = {
       return;
     }
 
     this._dbgProfilePath = debuggingProfileDir.path;
 
     // We would like to copy prefs into this new profile...
     let prefsFile = debuggingProfileDir.clone();
     prefsFile.append("prefs.js");
-
     // ... but unfortunately, when we run tests, it seems the starting profile
     // clears out the prefs file before re-writing it, and in practice the
     // file is empty when we get here. So just copying doesn't work in that
     // case.
     // We could force a sync pref flush and then copy it... but if we're doing
     // that, we might as well just flush directly to the new profile, which
     // always works:
-
-    // Before dumping the preferences to prefsFile, clear the current pref for
-    // extensions.lastAppVersion. The AddonManager expects this pref to be undefined
-    // when loading a new profile, this will trigger the installation of system addons
-    // without showing the addon update popup.
-    let appVersion = Services.prefs.getCharPref("extensions.lastAppVersion", "");
-    Services.prefs.clearUserPref("extensions.lastAppVersion");
-
     Services.prefs.savePrefFile(prefsFile);
 
-    // Restore the overridden extensions.lastAppVersion preference.
-    if (appVersion) {
-      Services.prefs.setCharPref("extensions.lastAppVersion", appVersion);
-    }
-
     dumpn("Finished creating the chrome toolbox user profile at: " +
           this._dbgProfilePath);
   },
 
   /**
    * Originally, the profile was placed in `ProfLD` instead of `ProfD`.  On some systems,
    * such as macOS, `ProfLD` is in the user's Caches directory, which is not an
    * appropriate place to store supposedly persistent profile data.